From: Hans de Goede <hdegoede@redhat.com>
To: "Mark Pearson" <markpearson@lenovo.com>,
"Barnabás Pőcze" <pobrn@protonmail.com>
Cc: "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"mario.limonciello@dell.com" <mario.limonciello@dell.com>,
"eliadevito@gmail.com" <eliadevito@gmail.com>,
"hadess@hadess.net" <hadess@hadess.net>,
"bberg@redhat.com" <bberg@redhat.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"dvhart@infradead.org" <dvhart@infradead.org>
Subject: Re: [External] Re: [PATCH 2/3] ACPI: platform-profile: Add platform profile support
Date: Wed, 11 Nov 2020 11:29:23 +0100 [thread overview]
Message-ID: <f4994ff1-ec00-5abe-039a-c7e8524ea054@redhat.com> (raw)
In-Reply-To: <72b0fb0a-8007-d795-8b1a-68fa58231c23@lenovo.com>
Hi,
On 11/10/20 3:32 PM, Mark Pearson wrote:
> Thanks Barnabas
>
> On 10/11/2020 05:15, Barnabás Pőcze wrote:
>> Hi
>>
>> I've added some questions and comments inline.
>>
>>
>>
>> 2020. november 10., kedd 4:31 keltezéssel, Mark Pearson írta:
<snip>
>>> + "Low-power",
>>> + "Cool",
>>> + "Quiet",
>>> + "Balance",
>>> + "Performance",
>>> + "Unknown"
>>
>> "unknown" is not documented, yet it may be returned to userspace.
> Ack - I'll look into if it's really needed, but it seemed sensible to have it whilst doing the implementation.
AFAIK with the currently agreed upon version of the API we do not need this,
please remove it. We can always add it later if necessary, but for now I would
like to avoid drivers being tempted to use this.
Regards,
Hans
next prev parent reply other threads:[~2020-11-11 10:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 3:31 [PATCH 0/3] Platform Profile support Mark Pearson
2020-11-10 3:31 ` [PATCH 1/3] Documentation: Add documentation for new platform_profile sysfs attribute Mark Pearson
2020-11-10 10:03 ` Andy Shevchenko
2020-11-10 14:09 ` [External] " Mark Pearson
2020-11-10 3:31 ` [PATCH 2/3] ACPI: platform-profile: Add platform profile support Mark Pearson
2020-11-10 10:15 ` Barnabás Pőcze
2020-11-10 14:32 ` [External] " Mark Pearson
2020-11-10 23:48 ` Barnabás Pőcze
2020-11-11 10:29 ` Hans de Goede [this message]
2020-11-10 10:26 ` Andy Shevchenko
2020-11-10 14:39 ` [External] " Mark Pearson
2020-11-10 12:53 ` Rafael J. Wysocki
2020-11-10 14:40 ` [External] " Mark Pearson
2020-11-10 3:31 ` [PATCH 3/3] platform/x86: thinkpad_acpi: " Mark Pearson
2020-11-10 10:06 ` Andy Shevchenko
2020-11-10 14:41 ` [External] " Mark Pearson
2020-11-19 16:37 ` [PATCH 0/3] Platform Profile support Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4994ff1-ec00-5abe-039a-c7e8524ea054@redhat.com \
--to=hdegoede@redhat.com \
--cc=bberg@redhat.com \
--cc=dvhart@infradead.org \
--cc=eliadevito@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-acpi@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=markpearson@lenovo.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox