From: Julian Sikorski <belegdol@gmail.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org
Cc: teohhanhui@gmail.com, Shyam-sundar.S-k@amd.com,
Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
Subject: Re: [PATCH 1/5] ACPI: PM: s2idle: Use correct revision id
Date: Thu, 17 Jun 2021 20:28:19 +0200 [thread overview]
Message-ID: <f50c6baf-a780-7a58-4083-88d53934290b@gmail.com> (raw)
In-Reply-To: <20210617164212.584-1-mario.limonciello@amd.com>
W dniu 17.06.2021 o 18:42, Mario Limonciello pisze:
> From: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
>
> AMD spec mentions only revision 0. With this change,
> device constraint list is populated properly.
>
> Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
> ---
> drivers/acpi/x86/s2idle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
> index 2d7ddb8a8cb6..da27c1c45c9f 100644
> --- a/drivers/acpi/x86/s2idle.c
> +++ b/drivers/acpi/x86/s2idle.c
> @@ -96,7 +96,7 @@ static void lpi_device_get_constraints_amd(void)
> int i, j, k;
>
> out_obj = acpi_evaluate_dsm_typed(lps0_device_handle, &lps0_dsm_guid,
> - 1, ACPI_LPS0_GET_DEVICE_CONSTRAINTS,
> + rev_id, ACPI_LPS0_GET_DEVICE_CONSTRAINTS,
> NULL, ACPI_TYPE_PACKAGE);
>
> if (!out_obj)
>
No regressions against [1] on my ASUS UM425IA. Suspend and resume still
work, provided other relevant patches are applied. I am testing on
Fedora 5.12 kernel [2].
Tested-by: Julian Sikorski <belegdol@gmail.com>
[1]
https://patchwork.kernel.org/project/linux-acpi/patch/20210317143842.786380-2-alexander.deucher@amd.com/
[2]
https://gitlab.com/belegdol/kernel-ark/-/commits/fedora-5.12-s0ix-8-upstream-newnvme
prev parent reply other threads:[~2021-06-17 18:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 16:42 [PATCH 1/5] ACPI: PM: s2idle: Use correct revision id Mario Limonciello
2021-06-17 16:42 ` [PATCH 2/5] ACPI: PM: s2idle: Refactor common code Mario Limonciello
2021-06-17 18:28 ` Julian Sikorski
2021-06-17 16:42 ` [PATCH 3/5] ACPI: PM: s2idle: Add support for multiple func mask Mario Limonciello
2021-06-17 18:28 ` Julian Sikorski
2021-06-18 16:30 ` Rafael J. Wysocki
2021-06-18 16:34 ` Limonciello, Mario
2021-06-18 16:41 ` Rafael J. Wysocki
2021-06-17 16:42 ` [PATCH 4/5] ACPI: PM: s2idle: Add support for new Microsoft UUID Mario Limonciello
2021-06-17 18:28 ` Julian Sikorski
2021-06-17 16:42 ` [PATCH 5/5] ACPI: PM: Adjust behavior for field problems on AMD systems Mario Limonciello
2021-06-17 18:28 ` Julian Sikorski
2021-06-18 8:05 ` Kai-Heng Feng
2021-06-17 18:28 ` Julian Sikorski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f50c6baf-a780-7a58-4083-88d53934290b@gmail.com \
--to=belegdol@gmail.com \
--cc=Pratik.Vishwakarma@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rjw@rjwysocki.net \
--cc=teohhanhui@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox