From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
Len Brown <len.brown@intel.com>
Subject: [PATCH 11/12] ACPI: battery drivers should call power_supply_changed()
Date: Tue, 06 Apr 2010 03:06:22 -0400 [thread overview]
Message-ID: <f79e1cec8c8aa64895fd7b595dc7b48157df0754.1270537380.git.len.brown@intel.com> (raw)
In-Reply-To: <1270537583-8756-1-git-send-email-lenb@kernel.org>
In-Reply-To: <dadf28a10c3eb29421837a2e413ab869ebd9e168.1270537380.git.len.brown@intel.com>
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Calling kobject_uevent() directly is a layering violation. In
particular, it means we'll miss updating the generic LED trigger.
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Acked-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/battery.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index 52df994..db78b6e 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -879,7 +879,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
#ifdef CONFIG_ACPI_SYSFS_POWER
/* acpi_battery_update could remove power_supply object */
if (battery->bat.dev)
- kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
+ power_supply_changed(&battery->bat);
#endif
}
--
1.6.0.6
next prev parent reply other threads:[~2010-04-06 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 7:06 ACPI patches for 2.6.34-rc3 Len Brown
2010-04-06 7:06 ` [PATCH 01/12] ACPI: EC: Allow multibyte access to EC Len Brown
2010-04-06 7:06 ` [PATCH 02/12] ACPI / PM: Move ACPI video resume to a PM notifier Len Brown
2010-04-06 18:55 ` Rafael J. Wysocki
2010-04-06 21:07 ` Len Brown
2010-04-06 7:06 ` [PATCH 03/12] ACPI dock: support multiple ACPI dock devices Len Brown
2010-04-06 7:06 ` [PATCH 04/12] ACPI: fixes a false alarm from lockdep Len Brown
2010-04-06 7:06 ` [PATCH 05/12] ACPI / ACPICA: Do not check reference counters in acpi_ev_enable_gpe() Len Brown
2010-04-06 7:06 ` [PATCH 06/12] ACPI: use _HID when supplied by root-level devices Len Brown
2010-04-06 7:06 ` [PATCH 07/12] ACPI: NUMA: map pxms to low node ids Len Brown
2010-04-06 7:06 ` [PATCH 08/12] ACPI: Don't send KEY_UNKNOWN for random video notifications Len Brown
2010-04-06 7:06 ` [PATCH 09/12] PNPACPI: truncate _CRS windows with _LEN > _MAX - _MIN + 1 Len Brown
2010-04-06 7:06 ` [PATCH 10/12] ACPI: battery: Fix CONFIG_ACPI_SYSFS_POWER=n Len Brown
2010-04-06 7:06 ` Len Brown [this message]
2010-04-06 7:06 ` [PATCH 12/12] ACPI: Reduce ACPI resource conflict message to KERN_WARNING, printk cleanup Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f79e1cec8c8aa64895fd7b595dc7b48157df0754.1270537380.git.len.brown@intel.com \
--to=lenb@kernel.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox