Re: [RFC PATCH 0/4] ACPI/IORT: Support for IORT RMR node

Steven Price
2020-11-06T15:22:08Z

On 28/10/2020 18:24, Shameerali Kolothum Thodi wrote:
> Hi Steve,
>
>> -----Original Message-----
>> From: Steven Price [mailto:steven.price@arm.com]
>> Sent: 28 October 2020 16:44
>> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>;
>> linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org;
>> iommu@lists.linux-foundation.org; devel@acpica.org
>> Cc: lorenzo.pieralisi@arm.com; joro@8bytes.org; Jonathan Cameron
>> <jonathan.cameron@huawei.com>; Linuxarm <linuxarm@huawei.com>;
>> Guohanjun (Hanjun Guo) <guohanjun@huawei.com>; robin.murphy@arm.com;
>> wanghuiqiang <wanghuiqiang@huawei.com>; Sami Mujawar
>> <Sami.Mujawar@arm.com>
>> Subject: Re: [RFC PATCH 0/4] ACPI/IORT: Support for IORT RMR node
>>
>> On 27/10/2020 11:26, Shameer Kolothum wrote:
>>> The series adds support to IORT RMR nodes specified in IORT
>>> Revision E -ARM DEN 0049E[0]. RMR nodes are used to describe memory
>>> ranges that are used by endpoints and require a unity mapping
>>> in SMMU.
>>
>> Hi Shameer,
>>
>> I've also been taking a look at RMR, and Sami is helping me get set up
>> so that I can do some testing. We're hoping to be able to test an EFI
>> framebuffer or splash screen - which has the added complication of the
>> unity mapping becoming redundant if a native display driver takes over
>> the display controller.
>>
>> I've looked through your series and the code looks correct to me.
>
> Thanks for taking a look and the details.
>
>> Hopefully I'll be able to give it some testing soon.
>
> Cool. Please update once you get a chance run the tests.

Hi Shameer,

Just to update on this, for the EFI framebuffer use case I hit exactly
the issue that Robin has mentioned in another thread - the RMR is
effectively ignored because the display controller isn't being handled
by Linux (so there's no device to link it to). The splash screen might
similarly flicker as the SMMU reset will initially block the traffic
before the RMR region is enabled.

Steve