From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6198C27C5E for ; Wed, 16 Aug 2023 22:37:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346886AbjHPWhU (ORCPT ); Wed, 16 Aug 2023 18:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346882AbjHPWgs (ORCPT ); Wed, 16 Aug 2023 18:36:48 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CEAC1B2; Wed, 16 Aug 2023 15:36:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692225407; x=1723761407; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=l1mTJmkp/kRwh+y4bLd5HMMSqSBCJpk7nRJ+5MwFhoU=; b=CE2/7hdUwRnfQHYn0FnREXd6MK7aWpgmXiptCQItfhHpjOhujv4NANk7 mB1uzUOMyQ8ZeaGE6LunJ82aYt6Fglvi4bMrthDlE0OZbCNI/K/mvMm4L sF9/+jbOuPy7XSuJTGuJctHw2ydYlly7ssmk+2v/P6GC0A7l0LXjVMj6r 61T43WPU3gV0Pl7YuNKasYQW4ODZI09n4OgJRJFudzGJOvyGIE/Yyp++q mdoiCUNCDuvqLU9PEPRT2ZPXMX8GoTm27EDccVWwIpXESJ9iO7U2jSYOw chPCD6mzrIr60NOVjKmc77qNQ2vfp+O42sT0e+tJJejJzkJ282iRuROvN Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="375422278" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="375422278" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2023 15:36:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="908162810" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="908162810" Received: from gokunbor-mobl1.amr.corp.intel.com (HELO [10.255.229.16]) ([10.255.229.16]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2023 15:36:46 -0700 Message-ID: Date: Wed, 16 Aug 2023 15:36:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 1/9] ACPI: Add comments to clarify some #ifdef statements Content-Language: en-US To: Mario Limonciello , "Rafael J . Wysocki" , Mika Westerberg , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , linux-acpi@vger.kernel.org, Iain Lane , Shyam-sundar S-k References: <20230816204143.66281-1-mario.limonciello@amd.com> <20230816204143.66281-2-mario.limonciello@amd.com> From: Kuppuswamy Sathyanarayanan In-Reply-To: <20230816204143.66281-2-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 8/16/2023 1:41 PM, Mario Limonciello wrote: > With nested #ifdef statements it's sometimes difficult to tell > which code goes with which statement. One comment was wrong, > so fix it and add another comment to clarify another. I would explain what is wrong clearly in the commit log. I see this file has many #ifdefs without comments. Do you want to fix them all? > Signed-off-by: Mario Limonciello > --- > v9->v10: > * no changes > --- > include/linux/acpi.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index 641dc48439873..0d5277b7c6323 100644 > --- a/include/linux/acpi.h > +++ b/include/linux/acpi.h > @@ -1117,10 +1117,10 @@ static inline void arch_reserve_mem_area(acpi_physical_address addr, > size_t size) > { > } > -#endif /* CONFIG_X86 */ > +#endif /* CONFIG_IA64 */ > #else > #define acpi_os_set_prepare_sleep(func, pm1a_ctrl, pm1b_ctrl) do { } while (0) > -#endif > +#endif /* CONFIG_ACPI */ > > #if defined(CONFIG_ACPI) && defined(CONFIG_PM) > int acpi_dev_suspend(struct device *dev, bool wakeup);