From: Ben Cheatham <benjamin.cheatham@amd.com>
To: Dan Williams <dan.j.williams@intel.com>,
dave@stogolabs.net, jonathan.cameron@huawei.com,
dave.jiang@intel.com, alison.schofield@intel.com,
vishal.l.verma@intel.com, ira.weiny@intel.com, rafael@kernel.org
Cc: linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v9 5/5] EINJ, Documentation: Update EINJ kernel doc
Date: Wed, 17 Jan 2024 10:15:05 -0600 [thread overview]
Message-ID: <fda7e3d8-c5d7-48c8-bf75-bc11af9455a8@amd.com> (raw)
In-Reply-To: <65a717cf9d6cb_3b8e294ec@dwillia2-xfh.jf.intel.com.notmuch>
On 1/16/24 5:57 PM, Dan Williams wrote:
> Ben Cheatham wrote:
>> Update EINJ kernel document to include how to inject CXL protocol error
>> types, build the kernel to include CXL error types, and give an example
>> injection.
>>
>> Signed-off-by: Ben Cheatham <Benjamin.Cheatham@amd.com>
>> ---
>> .../firmware-guide/acpi/apei/einj.rst | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/Documentation/firmware-guide/acpi/apei/einj.rst b/Documentation/firmware-guide/acpi/apei/einj.rst
>> index d6b61d22f525..a8f26845682a 100644
>> --- a/Documentation/firmware-guide/acpi/apei/einj.rst
>> +++ b/Documentation/firmware-guide/acpi/apei/einj.rst
>> @@ -181,6 +181,25 @@ You should see something like this in dmesg::
>> [22715.834759] EDAC sbridge MC3: PROCESSOR 0:306e7 TIME 1422553404 SOCKET 0 APIC 0
>> [22716.616173] EDAC MC3: 1 CE memory read error on CPU_SrcID#0_Channel#0_DIMM#0 (channel:0 slot:0 page:0x12345 offset:0x0 grain:32 syndrome:0x0 - area:DRAM err_code:0001:0090 socket:0 channel_mask:1 rank:0)
>>
>> +CXL error types are supported from ACPI 6.5 onwards. These error types
>> +are not available in the legacy interface at /sys/kernel/debug/apei/einj,
>> +and are instead at /sys/kernel/debug/cxl/. There is a file under debug/cxl
>> +called "einj_type" that is analagous to available_error_type under debug/cxl.
>
> s/analagous/analogous/
>
> Other than that, looks good.
Thanks for pointing that out!
Thanks,
Ben
prev parent reply other threads:[~2024-01-17 16:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 17:20 [PATCH v9 0/5] CXL, ACPI, APEI, EINJ: Update EINJ for CXL error types Ben Cheatham
2024-01-15 17:20 ` [PATCH v9 1/5] cxl, ACPI, APEI, EINJ: Add CXL_EINJ Kconfig option Ben Cheatham
2024-01-15 17:20 ` [PATCH v9 2/5] ACPI: Add CXL protocol error defines Ben Cheatham
2024-01-15 17:20 ` [PATCH v9 3/5] EINJ: Migrate to a platform driver Ben Cheatham
2024-01-16 23:47 ` Dan Williams
2024-01-17 16:14 ` Ben Cheatham
2024-01-15 17:20 ` [PATCH v9 4/5] cxl/core, EINJ: Add EINJ CXL debugfs files and EINJ helper functions Ben Cheatham
2024-01-16 23:58 ` Dan Williams
2024-01-17 16:14 ` Ben Cheatham
2024-01-17 0:06 ` Dan Williams
2024-01-17 16:15 ` Ben Cheatham
2024-01-15 17:20 ` [PATCH v9 5/5] EINJ, Documentation: Update EINJ kernel doc Ben Cheatham
2024-01-16 23:57 ` Dan Williams
2024-01-17 16:15 ` Ben Cheatham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fda7e3d8-c5d7-48c8-bf75-bc11af9455a8@amd.com \
--to=benjamin.cheatham@amd.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stogolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox