Re: [PATCH v2] ACPI: resource: Force irq1 edge low override on Infinity laptops

[Hans de Goede <hdegoede@redhat.com>]

Hi David,

Thank you for your patch.

On 1/3/24 15:03, David McFarland wrote:
> A user reported a keyboard problem similar to ones reported with other
> Zen laptops, on an Infinity E15-5A165-BM.
> 
> Add board name matches for this model and one (untested) close relative
> to tonfang_gm_rg, due to the board names' similarity to GMxRGxx.
> 
> Link: https://lemmy.ml/post/9864736
> Link: https://www.infinitygaming.com.au/bios/
> Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com

This patch seems to be based on an older version of the kernel.

Please base this on the latest code from:

https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/tree/?h=bleeding-edge

There is a single DMI match table there now for all AMD
laptops named irq1_edge_low_force_override[]

Which has a bunch of new entries, so your patch will not
apply cleanly as is.

Regards,

Hans




> ---
>  drivers/acpi/resource.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 297a88587031..6b64ea4e9c80 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -484,6 +484,18 @@ static const struct dmi_system_id tongfang_gm_rg[] = {
>  			DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
>  		},
>  	},
> +	{
> +		/* Infinity E15-5A165-BM */
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "GM5RG1E0009COM"),
> +		},
> +	},
> +	{
> +		/* Infinity E15-5A305-1M */
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
> +		},
> +	},
>  	{ }
>  };
>