public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Natalie Protasevich <Natalie.Protasevich@unisys.com>
Cc: Len Brown <lenb@kernel.org>, Andi Kleen <ak@suse.de>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH] i386: irq: Kill IRQ compression
Date: Fri, 16 Feb 2007 02:21:56 -0700	[thread overview]
Message-ID: <m18xeyh2yz.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <m1wt2ih7i0.fsf@ebiederm.dsl.xmission.com> (Eric W. Biederman's message of "Fri, 16 Feb 2007 00:44:07 -0700")

ebiederm@xmission.com (Eric W. Biederman) writes:

> By itself I don't think we are going to observe any real problems
> with this patch.
>
> However if we are going to be serious about this we need to do a
> few more things.
>
> - kill ioapic_renumber_irq.

Looking closer ioapic_renumber_irq does not appear to be an irq
compress thing.  Rather it appears to be a work around for a weird
acpi implementation where gsi 0 - 15 are not the ISA irqs. 

Natalie is my reading of the code there correct?

If so keeping ioapic_renumber_irq makes sense.  Although giving
it a name that suggests it is working around weird implementation
details would be good.

Eric

  reply	other threads:[~2007-02-16  9:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16  5:15 [PATCH] i386: irq: Kill IRQ compression Len Brown
2007-02-16  7:44 ` Eric W. Biederman
2007-02-16  9:21   ` Eric W. Biederman [this message]
2007-02-16  9:51 ` [PATCH] i386 irq: Kill NR_IRQ_VECTORS and increase NR_IRQS Eric W. Biederman
2007-02-16 10:15   ` Andi Kleen
2007-02-16 10:33     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m18xeyh2yz.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=Natalie.Protasevich@unisys.com \
    --cc=ak@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox