Re: VMware and ACPI

[Jan Rychter <jan-JAsPCFd0eodBDgjK7y7TUQ@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1388 bytes --]

>>>>> "Jan" == Jan Rychter <jan-JAsPCFd0eodBDgjK7y7TUQ@public.gmane.org> writes:
>>>>> "Frank" == Frank Mehnert <fm3-IG//nw+yl+iQIjdd1DhZXWfrygkm6VTR@public.gmane.org> writes:
 Frank> On Monday 15 September 2003 23:51, Jan Rychter wrote:
 > Hmm... just wondering: what happened to the VMware/ACPI interaction
 > issues that some people were reporting here?
 >
 > There were some discussions and it seemed that ACPI idling the
 > processor while VMware really wanted to use it was the cuplrit. Any
 > resulting changes?
 >
 > I'm running 2.4.22-pre10 now and my WindowsXP inside VMware runs
 > horribly slow. It gets considerably better if I leave an USB device
 > plugged in (which causes ACPI to use C2 only and never go into C3),
 > but it still isn't full speed.

 Frank> Yes, there is still a problem. I use the appending patch since
 Frank> ages. Before starting VMware, I do

 Frank> echo -n "0" > /proc/acpi/processor/CPU/power
 Jan> [...]

 Jan> Thanks. I'll apply this patch.

 Jan> Is there any chance that this kind of patch could make it into the
 Jan> mainline? It is really needed for some of us (everybody running
 Jan> VMware, for one).

Here is the patch slightly fixed for the ACPI in 2.4.22 (the old one did
not compile).

Could we please make it go in as a temporary workaround, so that people
can actually use VMware on Linux?

--J.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: acpi_no_idle.diff --]
[-- Type: text/x-patch, Size: 1322 bytes --]

--- drivers/acpi/processor.c.orig	2003-09-18 20:31:59.000000000 -0700
+++ drivers/acpi/processor.c	2003-09-18 20:48:51.000000000 -0700
@@ -1677,6 +1677,39 @@
 
 
 static int
+acpi_processor_write_power (
+        struct file  *file,
+        const char  *buffer,
+        unsigned long  count,
+        void   *data)
+{
+ struct acpi_processor *pr = (struct acpi_processor *) data;
+ char   state_string[2] = {'\0'};
+	
+ ACPI_FUNCTION_TRACE("acpi_processor_write_power");
+
+ if (!pr || (count > sizeof(state_string) - 1))
+  return_VALUE(-EINVAL);
+ 
+ if (copy_from_user(state_string, buffer, count))
+  return_VALUE(-EFAULT);
+ 
+ state_string[count] = '\0';
+
+ if (state_string[0] == '1') {
+     printk(KERN_INFO PREFIX "enabling acpi idle\n");
+     pm_idle = acpi_processor_idle;
+ } else {
+     printk(KERN_INFO PREFIX "disabling acpi idle\n");
+     pm_idle = pm_idle_save;
+     acpi_processor_power_activate(pr, ACPI_STATE_C1);
+ }
+
+ return_VALUE(count);
+}
+
+
+static int
 acpi_processor_read_performance (
 	char			*page,
 	char			**start,
@@ -1982,6 +2015,7 @@
 			ACPI_PROCESSOR_FILE_POWER));
 	else {
 		entry->read_proc = acpi_processor_read_power;
+		entry->write_proc = acpi_processor_write_power;
 		entry->data = acpi_driver_data(device);
 	}
 

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]