From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Domsch <Matt_Domsch@dell.com>,
hostmaster@ed-soft.at
Subject: Re: [PATCH 1/1] EFI iounpam fix for acpi_os_unmap_memory
Date: 21 Feb 2006 15:15:21 +0100 [thread overview]
Message-ID: <p73ek1w4x3a.fsf@verdi.suse.de> (raw)
In-Reply-To: <20060220220219.6d82366a.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> writes:
>
> void acpi_os_unmap_memory(void __iomem * virt, acpi_size size)
> {
> + /* Don't unmap memory which was not mapped by acpi_os_map_memory */
> + if (efi_enabled &&
> + (efi_mem_attributes(virt_to_phys(virt)) & EFI_MEMORY_WB))
> + return;
The patch is wrong because if the address came from ioremap
virt_to_phys doesn't give the real physical address. Also looking
at acpi_os_map_memory it doesn't quite match the logic there.
One working way to check for ioremap memory is
virt >= VMALLOC_START && virt < VMALLOC_END
-Andi
next prev parent reply other threads:[~2006-02-21 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 23:36 [PATCH 1/1] EFI iounpam fix for acpi_os_unmap_memory Edgar Hucek
2006-02-21 6:02 ` Andrew Morton
2006-02-21 14:15 ` Andi Kleen [this message]
2006-02-21 20:59 ` Andrew Morton
2006-02-21 21:09 ` Andi Kleen
2006-02-22 6:50 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73ek1w4x3a.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=Matt_Domsch@dell.com \
--cc=akpm@osdl.org \
--cc=hostmaster@ed-soft.at \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox