From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Adrian Bunk <bunk@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Alexey Starikovskiy <aystarik@gmail.com>,
lenb@kernel.org, astarikovskiy@suse.de,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [patch] x86: phase out forced inlining
Date: Tue, 04 Mar 2008 10:50:11 +0100 [thread overview]
Message-ID: <p73prua6coc.fsf@bingen.suse.de> (raw)
In-Reply-To: <20080304000031.49b558b8.akpm@linux-foundation.org> (Andrew Morton's message of "Tue\, 4 Mar 2008 00\:00\:31 -0800")
Andrew Morton <akpm@linux-foundation.org> writes:
>
> This was 2.5.x - you'll need to look in the historical-git tree.
>
> Here it is:
>
>
>
> : commit 4507a6a59cfc6997e532cd812a8bd244181e6205
> : Author: akpm <akpm>
> : Date: Tue Mar 11 07:42:00 2003 +0000
> :
> : [PATCH] work around gcc-3.x inlining bugs
> :
> : Force inlining even when gcc-3.x is too confused to do it for us.
I think these old inlining bugs were just caused by missing __always_inline
(e.g. in the vsyscall code which requires forced inlining or in copy_*_user)
AFAIK these all have __always_inline these days and if any are still missing these
are easy to change over as needed.
So Ingo's change is likely ok.
-Andi
next prev parent reply other threads:[~2008-03-04 9:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 16:19 [2.6 patch] acpi/battery.c: make 2 functions static Adrian Bunk
2008-03-01 18:26 ` Alexey Starikovskiy
2008-03-01 18:35 ` Adrian Bunk
2008-03-01 18:42 ` Alexey Starikovskiy
2008-03-01 18:45 ` Adrian Bunk
2008-03-03 8:57 ` Ingo Molnar
2008-03-03 9:13 ` Adrian Bunk
2008-03-03 9:17 ` Ingo Molnar
2008-03-03 9:31 ` Sam Ravnborg
2008-03-03 9:48 ` Adrian Bunk
2008-03-03 10:39 ` Ingo Molnar
2008-03-03 11:34 ` Adrian Bunk
2008-03-03 11:45 ` Ingo Molnar
2008-03-03 12:02 ` Adrian Bunk
2008-03-03 12:10 ` Ingo Molnar
2008-03-03 12:29 ` Adrian Bunk
2008-03-03 12:50 ` Ingo Molnar
2008-03-03 14:54 ` Adrian Bunk
2008-03-03 15:01 ` Adrian Bunk
2008-03-04 13:16 ` Ingo Molnar
2008-03-04 13:47 ` Adrian Bunk
2008-03-04 14:22 ` Ingo Molnar
2008-03-04 14:36 ` Jörn Engel
2008-03-04 14:45 ` Ingo Molnar
2008-03-03 12:13 ` [patch] x86: phase out forced inlining Ingo Molnar
2008-03-03 14:56 ` Sam Ravnborg
2008-03-04 16:46 ` Ingo Molnar
2008-03-04 18:07 ` Harvey Harrison
2008-03-04 18:09 ` H. Peter Anvin
2008-03-04 18:14 ` Harvey Harrison
2008-03-04 18:18 ` Harvey Harrison
2008-03-03 15:01 ` Arjan van de Ven
2008-03-03 15:58 ` Harvey Harrison
2008-03-04 6:42 ` Andrew Morton
2008-03-04 7:32 ` Ingo Molnar
2008-03-04 8:00 ` Andrew Morton
2008-03-04 9:50 ` Andi Kleen [this message]
2008-03-04 8:03 ` Sam Ravnborg
2008-03-04 8:38 ` Andrew Morton
2008-03-03 9:45 ` [2.6 patch] acpi/battery.c: make 2 functions static Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73prua6coc.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=astarikovskiy@suse.de \
--cc=aystarik@gmail.com \
--cc=bunk@kernel.org \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox