From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC
Date: Mon, 04 Sep 2017 15:50:50 +0200
Message-ID: <s5h1snmr2rp.wl-tiwai@suse.de>
References: <20170824081141.5018-1-tiwai@suse.de>
        <20170824081141.5018-2-tiwai@suse.de>
        <20170904133732.ll6cmuvnxja242gi@dell>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from mx2.suse.de ([195.135.220.15]:51515 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1753614AbdIDNuw (ORCPT <rfc822;linux-acpi@vger.kernel.org>);
        Mon, 4 Sep 2017 09:50:52 -0400
In-Reply-To: <20170904133732.ll6cmuvnxja242gi@dell>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, Darren Hart <dvhart@infradead.org>, Andy Shevchenko <andy@infradead.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Mika Westerberg <mika.westerberg@linux.intel.com>, Johannes Stezenbach <js@sig21.net>, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org

On Mon, 04 Sep 2017 15:37:32 +0200,
Lee Jones wrote:
> 
> > +static struct mfd_cell dc_ti_dev[] = {
> > +	{
> > +		.name = "dc_ti_pwrbtn",
> > +		.num_resources = ARRAY_SIZE(power_button_resources),
> > +		.resources = power_button_resources,
> > +	},
> > +	{
> 
> Place these on the same line.

Does this and ...


> > +	},
> > +	{
> > +		.name = "dc_ti_region",
> > +	},
> 
> This should be a one line entry:
> 
> 	{ .name = "dc_ti_region" },

.... this match together?  The result would be like:

static struct mfd_cell dc_ti_dev[] = {
	{
		.name = "dc_ti_pwrbtn",
		.num_resources = ARRAY_SIZE(power_button_resources),
		.resources = power_button_resources,
	}, {
		.name = "chtdc_ti_adc",
		.num_resources = ARRAY_SIZE(adc_resources),
	.....
	}, {	.name = "chtdc_ti_region",	},
};

which I find a bit inconsistent.


thanks,

Takashi