From: Takashi Iwai <tiwai@suse.de>
To: Stefan Binding <sbinding@opensource.cirrus.com>
Cc: Mark Brown <broonie@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
<patches@opensource.cirrus.com>,
Lucas Tanure <tanureal@opensource.cirrus.com>
Subject: Re: [PATCH v5 8/9] ALSA: hda/realtek: Add support for HP Laptops
Date: Fri, 21 Jan 2022 15:44:02 +0100 [thread overview]
Message-ID: <s5hlez9rvwt.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220121143254.6432-9-sbinding@opensource.cirrus.com>
On Fri, 21 Jan 2022 15:32:53 +0100,
Stefan Binding wrote:
>
> @@ -8926,7 +8953,21 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED),
> - SND_PCI_QUIRK(0x103c, 0x89c3, "HP", ALC285_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x896E, "HP EliteBook x360 830 G9", ALC245_FIXUP_CS35L41_SPI_2),
Please use lower letters for the hex number to align with others.
(Also other lines you've added.)
Though, it's no urgent problem, and we can fix it later if the whole
patch set can be merged now. If v3 needs to be respinned, please
apply the fix.
With the correction to be done,
Acked-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
next prev parent reply other threads:[~2022-01-21 14:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 14:32 [PATCH v5 0/9] Support Spi in i2c-multi-instantiate driver Stefan Binding
2022-01-21 14:32 ` [PATCH v5 1/9] spi: Make spi_alloc_device and spi_add_device public again Stefan Binding
2022-01-21 14:32 ` [PATCH v5 2/9] spi: Create helper API to lookup ACPI info for spi device Stefan Binding
2022-01-21 14:32 ` [PATCH v5 3/9] spi: Support selection of the index of the ACPI Spi Resource before alloc Stefan Binding
2022-01-21 14:32 ` [PATCH v5 4/9] spi: Add API to count spi acpi resources Stefan Binding
2022-01-21 14:32 ` [PATCH v5 5/9] platform/x86: i2c-multi-instantiate: Rename it for a generic serial driver name Stefan Binding
2022-01-21 15:12 ` Rafael J. Wysocki
2022-01-21 14:32 ` [PATCH v5 6/9] platform/x86: serial-multi-instantiate: Reorganize I2C functions Stefan Binding
2022-01-21 15:27 ` Rafael J. Wysocki
2022-01-21 14:32 ` [PATCH v5 7/9] platform/x86: serial-multi-instantiate: Add SPI support Stefan Binding
2022-01-21 15:31 ` Rafael J. Wysocki
2022-01-21 16:55 ` Stefan Binding
2022-01-21 17:14 ` Rafael J. Wysocki
2022-01-26 15:19 ` Stefan Binding
2022-01-21 14:32 ` [PATCH v5 8/9] ALSA: hda/realtek: Add support for HP Laptops Stefan Binding
2022-01-21 14:44 ` Takashi Iwai [this message]
2022-01-21 14:32 ` [PATCH v5 9/9] ACPI / scan: Create platform device for CS35L41 Stefan Binding
2022-01-21 16:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hlez9rvwt.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sbinding@opensource.cirrus.com \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).