From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v5 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC Date: Tue, 05 Sep 2017 09:46:08 +0200 Message-ID: References: <20170904144340.27693-1-tiwai@suse.de> <20170904144340.27693-2-tiwai@suse.de> <20170905072451.ephscqjqgwpnl6da@dell> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from mx2.suse.de ([195.135.220.15]:37618 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750729AbdIEHqK (ORCPT ); Tue, 5 Sep 2017 03:46:10 -0400 In-Reply-To: <20170905072451.ephscqjqgwpnl6da@dell> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Lee Jones Cc: Darren Hart , Andy Shevchenko , "Rafael J . Wysocki" , Mika Westerberg , Johannes Stezenbach , Hans de Goede , Dmitry Torokhov , platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 05 Sep 2017 09:24:51 +0200, Lee Jones wrote: > > On Mon, 04 Sep 2017, Takashi Iwai wrote: > > > This patch adds the MFD driver for Dollar Cove (TI version) PMIC with > > ACPI INT33F5 that is found on some Intel Cherry Trail devices. > > The driver is based on the original work by Intel, found at: > > https://github.com/01org/ProductionKernelQuilts > > > > This is a minimal version for adding the basic resources. Currently, > > only ACPI PMIC opregion and the external power-button are used. > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=193891 > > Reviewed-by: Mika Westerberg > > Reviewed-by: Andy Shevchenko > > Signed-off-by: Takashi Iwai > > --- > > v4->v5: > > * Minor coding-style fixes suggested by Lee > > * Put GPL text > > v3->v4: > > * no change for this patch > > v2->v3: > > * Rename dc_ti with chtdc_ti in all places > > * Driver/kconfig renames accordingly > > * Added acks by Andy and Mika > > v1->v2: > > * Minor cleanups as suggested by Andy > > > > drivers/mfd/Kconfig | 13 +++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/intel_soc_pmic_chtdc_ti.c | 184 ++++++++++++++++++++++++++++++++++ > > 3 files changed, 198 insertions(+) > > create mode 100644 drivers/mfd/intel_soc_pmic_chtdc_ti.c > > For my own reference: > Acked-for-MFD-by: Lee Jones Thanks! Now the question is how to deal with these. It's no critical things, so I'm OK to postpone for 4.15. OTOH, it's really a new device-specific stuff, thus it can't break anything else, and it'd be fairly safe to add it for 4.14 although it's at a bit late stage. IMO, it'd be great if you can carry all stuff through MFD tree; or create an immutable branch (again). But how to handle it, when to do it, It's all up to you guys. thanks, Takashi