From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 3/3] ACPI / PMIC: Add opregion driver for Intel Dollar Cove TI PMIC
Date: Tue, 22 Aug 2017 12:25:12 +0200
Message-ID: <s5ho9r7aohj.wl-tiwai@suse.de>
References: <20170822055710.26515-1-tiwai@suse.de>
        <20170822055710.26515-4-tiwai@suse.de>
        <1503395915.25945.48.camel@linux.intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from mx2.suse.de ([195.135.220.15]:52170 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S932156AbdHVKZO (ORCPT <rfc822;linux-acpi@vger.kernel.org>);
        Tue, 22 Aug 2017 06:25:14 -0400
In-Reply-To: <1503395915.25945.48.camel@linux.intel.com>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Mika Westerberg <mika.westerberg@linux.intel.com>, Johannes Stezenbach <js@sig21.net>, linux-input@vger.kernel.org, linux-acpi@vger.kernel.org

On Tue, 22 Aug 2017 11:58:35 +0200,
Andy Shevchenko wrote:
> 
> On Tue, 2017-08-22 at 07:57 +0200, Takashi Iwai wrote:
> > This patch adds the opregion driver for Dollar Cove TI PMIC on Intel
> > Cherry Trail devices.  The patch is based on the original work by
> > Intel, found at:
> >       https://github.com/01org/ProductionKernelQuilts
> > with many cleanups and rewrites.
> > 
> > The driver is currently provided only as built-in to follow other
> > PMIC opregion drivers convention.
> > 
> > The re-enumeration of devices at probe is required for fixing the
> > issues on HP x2 210 G2.  See bug#195689.
> > 
> > 
> 
> > +static int dc_ti_pmic_get_raw_temp(struct regmap *regmap, int reg)
> > +{
> > +	int temp_l, temp_h;
> > +
> > +	if (regmap_read(regmap, reg, &temp_l) ||
> > +	    regmap_read(regmap, reg - 1, &temp_h))
> > +		return -EIO;
> > +
> > +	return temp_l | (temp_h & 0x3) << 8;
> > +}
> 
> I'm not sure I understand this "- 1" part along with choice of l and h
> suffixes.
> 
> Does it mean the register is big endian?

Good point, I need to check the original code and the values.
This can be a typo of '+', of course.


thanks,

Takashi