From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Re: [Alsa-devel] [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (1/2) Date: Thu, 28 Jul 2005 10:06:35 +0200 Message-ID: References: <200507261247.05684.rjw@sisk.pl> <200507261251.48291.rjw@sisk.pl> <20050727205249.GA708@openzaurus.ucw.cz> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20050727205249.GA708-u08AdweFZfgxtPtxi4kahqVXKuFTiq87@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Pavel Machek Cc: "Rafael J. Wysocki" , LKML , ACPI mailing list , Andrew Morton , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org List-Id: linux-acpi@vger.kernel.org At Wed, 27 Jul 2005 22:52:49 +0200, Pavel Machek wrote: > > Hi! > > > > The following patch adds free_irq() and request_irq() to the suspend and > > > resume, respectively, routines in the snd_intel8x0 driver. > > > > The patch looks OK to me although I have some concerns. > > > > - The error in resume can't be handled properly. > > > > What should we do for the error of request_irq()? > > > > - Adding this to all drivers seem too much. > > There's probably no other way. Talk to Len Brown. > > > We just need to stop the irq processing until resume, so something > > like suspend_irq(irq, dev_id) and resume_irq(irq, dev_id) would be > > more uesful? > > Its more complex than that. Irq numbers may change during resume. Hmm, then the patch looks wrong. It assumes that the irq number is as same as before suspend. Sorry for ignorance, but, is only irq affected? Are the other resources like ioport consistent after resume? Takashi ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf