* Re:
@ 2003-01-03 8:43 hotdi-049YEbzBPRy2DcrEJY9i8Q
0 siblings, 0 replies; 21+ messages in thread
From: hotdi-049YEbzBPRy2DcrEJY9i8Q @ 2003-01-03 8:43 UTC (permalink / raw)
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
confirm 191616
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
[not found] ` <200402040504.i1454nSA026612-X7uhcDA/9l0r6e4dAyNacUYNSvWw4lR0@public.gmane.org>
@ 2004-02-04 5:04 ` Design Patterns Source reflector
0 siblings, 0 replies; 21+ messages in thread
From: Design Patterns Source reflector @ 2004-02-04 5:04 UTC (permalink / raw)
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
To get the source for the Design Patterns book, please send
a message with "send design pattern source" as the subject.
If you want a version that is zipped (instead of tarred),
please use "send zipped" as the subject. If you want a version
in German, send "send German design pattern source" as the subject.
You can also try ftp to st.cs.uiuc.edu in /pub/patterns/dpcat,
or look at the patterns home page
(http://st-www.cs.uiuc.edu/patterns/patterns.html)
If you can't get ANYTHING to work, complain to johnson-Tmj1lob9twqeodoxqx+5/w@public.gmane.org
Thanks!
The source server.
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
@ 2004-07-19 4:53 Mj
0 siblings, 0 replies; 21+ messages in thread
From: Mj @ 2004-07-19 4:53 UTC (permalink / raw)
To: Acpi-devel
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
------------------ Virus Warning Message (on the network)
Found virus WORM_BAGLE.AG in file Dog.exe
The file Dog.exe can not be moved because /var/quarantine/virus/virAIFT6oWfZ: No space left on device.
This is a machine-generated message, please do not reply via e-mail. If you have questions, please contact the Lucent Help Desk at +1 888 300 0770.
---------------------------------------------------------
[-- Attachment #2: Type: text/html, Size: 49 bytes --]
[-- Attachment #3: Type: text/plain, Size: 177 bytes --]
------------------ Virus Warning Message (on the network)
Dog.exe is removed from here because it contains a virus.
---------------------------------------------------------
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
@ 2004-07-19 7:29 Mj
0 siblings, 0 replies; 21+ messages in thread
From: Mj @ 2004-07-19 7:29 UTC (permalink / raw)
To: Acpi-devel
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
------------------ Virus Warning Message (on the network)
Found virus WORM_BAGLE.AG in file Garry.com
The file Garry.com can not be moved because /var/quarantine/virus/virJWWjgUxMt: No space left on device.
This is a machine-generated message, please do not reply via e-mail. If you have questions, please contact the Lucent Help Desk at +1 888 300 0770.
---------------------------------------------------------
[-- Attachment #2: Type: text/html, Size: 53 bytes --]
[-- Attachment #3: Type: text/plain, Size: 179 bytes --]
------------------ Virus Warning Message (on the network)
Garry.com is removed from here because it contains a virus.
---------------------------------------------------------
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
@ 2005-07-05 23:28 =?ISO-2022-JP?B?GyRCJCpKdSU1ITwlQRsoQiA8b3Rha2FyYWdldHRlckB5YWhvby5jb20+?=
0 siblings, 0 replies; 21+ messages in thread
From: =?ISO-2022-JP?B?GyRCJCpKdSU1ITwlQRsoQiA8b3Rha2FyYWdldHRlckB5YWhvby5jb20+?= @ 2005-07-05 23:28 UTC (permalink / raw)
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
nkEqå¶ElÈÌvCx[gGb`ÉüI
ÞÌOKðàçÁÄBeII
¢«ÈèÌJüɬ·éÞ½¿BB
µ©àvCÉàüAÞÌ©ÂßéOÅ©mçÊj½¿ðó¯üêéÌq¥¥¥B
µ©µ¾ñ¾ñAÞ½¿ÌÌðõ´ªïÝÝnß饥¥
http://hamex.tv/index2.php?35
ÞÈOðmçÈ©Á½ÌqàAiÆÍá¤vCÉ©ªðYêÄõ´ðß饥¥B
flÈçÅÍÌvZūȢANVÉå»±Ôá¢ÈµÅ·BBB
»µÄÅãÍ¥¥¥
http://hamex.tv/index2.php?35
NSLSRJGIOJ
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
@ 2005-11-15 9:20 yuki
0 siblings, 0 replies; 21+ messages in thread
From: yuki @ 2005-11-15 9:20 UTC (permalink / raw)
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
®«S«³«¿««g«¢«ú«è«
ª®ª®ª®ª®ª®ª®ª®ª®ª®
@@@@@@@@¤¤¤¤¤¤
http://www.checkcheck-zero.net/?id=pc120
üïï^Nïï
[óMM
zÌè^²ßõ
Ê^^®æÌo^{
Z^AhX^dbÔÌð·
j««ÆàÉ®S³¿ÅSIJp¸¯Ü·B
http://www.checkcheck-zero.net/?id=pc120
ÀSTCgé¾
EEEcªªªªªªªªªªªªªªªªªªªªªªªªª
u[[ÍX|T[TCgl©çÌL¿ÌÝÅ^cµÄ¨èÜ·B
»Ì×AST[rXð®S³¿ÅSIJp¸¯Ü·B
zÌèðßéûXÉÀSÆMðæêÉl¦ÈªçA
Cyɨg¢¸¯éT[rXðÚwµA
SÌT|[ģÅFlÉÁ½¨èTµð¨è`¢µÄ¨èÜ·B
ªªªªªªªªªªªªªªªªªªªªªªªªªcEEE
http://www.checkcheck-zero.net/?id=pc120
--
zMÛF
kissme_rej-OKxsdJkEjlFWk0Htik3J/w@public.gmane.org
-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today
Register for a JBoss Training Course. Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
^ permalink raw reply [flat|nested] 21+ messages in thread
* RE;
@ 2010-04-02 23:17 Mrs Claire page
0 siblings, 0 replies; 21+ messages in thread
From: Mrs Claire page @ 2010-04-02 23:17 UTC (permalink / raw)
I am Mrs Claire page,contact my lawyer(barlandon_watson@gala.net)
^ permalink raw reply [flat|nested] 21+ messages in thread
* RE:
@ 2010-06-05 3:47 MR PETER LUK
0 siblings, 0 replies; 21+ messages in thread
From: MR PETER LUK @ 2010-06-05 3:47 UTC (permalink / raw)
To: info
I have a business proposal to share with you.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
@ 2010-07-17 2:41 SINOPEC OIL AND GAS COMPANY
0 siblings, 0 replies; 21+ messages in thread
From: SINOPEC OIL AND GAS COMPANY @ 2010-07-17 2:41 UTC (permalink / raw)
Dear winner,
We the SINOPEC OIL AND GAS COMPANY board of directors like to officially
congratulate you for the draw that was just held by our company which
featured you as the second place winner.Prizes won : Brand New 2010
Lamborghini Car new model and The Sum Of $570,000.00USD
(United State Dollars) cash.
FILL DETAILs BELOW;
Your Full Name : Address :Country :Phone number :Age :Gender :Occupation :
Yours,
Sinopec Oil And Gas Corp.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
@ 2010-09-28 12:23 Marc Ferland
0 siblings, 0 replies; 21+ messages in thread
From: Marc Ferland @ 2010-09-28 12:23 UTC (permalink / raw)
hey,
how are you?
Just received my Iphone 4G 16GB from this homepage, www.Benefits188.com
It's so cheaper but genuine, Wow. that's amazing. I like it very much!!
I paid it $690US couier charges included , They have some other
products. If you want to get one. you can check it out !
Regards,
Marc Ferland
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
@ 2011-05-01 13:35 lotto
0 siblings, 0 replies; 21+ messages in thread
From: lotto @ 2011-05-01 13:35 UTC (permalink / raw)
Send your Names*Address*Phone* to claim your 1,000,000 GBP awarded to
you.Reply to lotto_agent1@ymail.com for more info
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
2012-10-30 17:42 ` (unknown), Yinghai Lu
@ 2012-11-02 0:17 ` Rafael J. Wysocki
2012-11-05 22:27 ` Re: Bjorn Helgaas
2012-11-06 5:03 ` Taku Izumi
1 sibling, 1 reply; 21+ messages in thread
From: Rafael J. Wysocki @ 2012-11-02 0:17 UTC (permalink / raw)
To: Yinghai Lu
Cc: Bjorn Helgaas, Len Brown, Taku Izumi, Jiang Liu, linux-pci,
linux-acpi
Hi,
On Tuesday, October 30, 2012 10:42:37 AM Yinghai Lu wrote:
> Subject: [PATCH resend 0/8] PCI, ACPI, x86: pci root bus hotplug support resources assign and remove path
>
> 1. add support for assign resource for hot add path.
> 2. stop and remove root bus during acpi root remove.
>
>
> could get from
> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci-root-bus-hotplug
>
> Yinghai Lu (8):
> PCI: Separate out pci_assign_unassigned_bus_resources()
> PCI: Move pci_rescan_bus() back to probe.c
> PCI: Move out pci_enable_bridges out of assign_unsigned_bus_res
> PCI, ACPI: assign unassigned resource for hot add root bus
> PCI: Add pci_stop/remove_root_bus()
> PCI, ACPI: Make acpi_pci_root_remove stop/remove pci root bus
> PCI, ACPI: delete root bus prt during hot remove path
> PCI, ACPI: remove acpi_root_driver in reserse order
>
> drivers/acpi/pci_root.c | 21 ++++++++++++++++++++-
> drivers/pci/probe.c | 22 ++++++++++++++++++++++
> drivers/pci/remove.c | 36 ++++++++++++++++++++++++++++++++++++
> drivers/pci/setup-bus.c | 22 +---------------------
> include/linux/pci.h | 3 +++
> 5 files changed, 82 insertions(+), 22 deletions(-)
Please feel free to add
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
to the ACPI-related patches in this series.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
2012-11-02 0:17 ` Rafael J. Wysocki
@ 2012-11-05 22:27 ` Bjorn Helgaas
2012-11-05 22:49 ` Re: Yinghai Lu
0 siblings, 1 reply; 21+ messages in thread
From: Bjorn Helgaas @ 2012-11-05 22:27 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Yinghai Lu, Len Brown, Taku Izumi, Jiang Liu, linux-pci,
linux-acpi
On Thu, Nov 1, 2012 at 6:17 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> Hi,
>
> On Tuesday, October 30, 2012 10:42:37 AM Yinghai Lu wrote:
>> Subject: [PATCH resend 0/8] PCI, ACPI, x86: pci root bus hotplug support resources assign and remove path
>>
>> 1. add support for assign resource for hot add path.
>> 2. stop and remove root bus during acpi root remove.
>>
>>
>> could get from
>> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci-root-bus-hotplug
>>
>> Yinghai Lu (8):
>> PCI: Separate out pci_assign_unassigned_bus_resources()
>> PCI: Move pci_rescan_bus() back to probe.c
>> PCI: Move out pci_enable_bridges out of assign_unsigned_bus_res
>> PCI, ACPI: assign unassigned resource for hot add root bus
>> PCI: Add pci_stop/remove_root_bus()
>> PCI, ACPI: Make acpi_pci_root_remove stop/remove pci root bus
>> PCI, ACPI: delete root bus prt during hot remove path
>> PCI, ACPI: remove acpi_root_driver in reserse order
>>
>> drivers/acpi/pci_root.c | 21 ++++++++++++++++++++-
>> drivers/pci/probe.c | 22 ++++++++++++++++++++++
>> drivers/pci/remove.c | 36 ++++++++++++++++++++++++++++++++++++
>> drivers/pci/setup-bus.c | 22 +---------------------
>> include/linux/pci.h | 3 +++
>> 5 files changed, 82 insertions(+), 22 deletions(-)
>
> Please feel free to add
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> to the ACPI-related patches in this series.
I applied these to my pci/yinghai-for-pci-root-bus-hotplug branch as
v3.8 material. They should appear in "next" tomorrow. Thanks!
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
2012-11-05 22:27 ` Re: Bjorn Helgaas
@ 2012-11-05 22:49 ` Yinghai Lu
0 siblings, 0 replies; 21+ messages in thread
From: Yinghai Lu @ 2012-11-05 22:49 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Rafael J. Wysocki, Len Brown, Taku Izumi, Jiang Liu, linux-pci,
linux-acpi
On Mon, Nov 5, 2012 at 2:27 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> I applied these to my pci/yinghai-for-pci-root-bus-hotplug branch as
> v3.8 material. They should appear in "next" tomorrow. Thanks!
Thanks...
please check batch 2 at
https://patchwork.kernel.org/patch/1693211/
Yinghai
^ permalink raw reply [flat|nested] 21+ messages in thread
* RE:
2012-10-30 17:42 ` (unknown), Yinghai Lu
2012-11-02 0:17 ` Rafael J. Wysocki
@ 2012-11-06 5:03 ` Taku Izumi
1 sibling, 0 replies; 21+ messages in thread
From: Taku Izumi @ 2012-11-06 5:03 UTC (permalink / raw)
To: 'Yinghai Lu'
Cc: linux-pci, linux-acpi, 'Bjorn Helgaas',
'Len Brown', 'Jiang Liu'
Reviewed and tested by Taku Izumi <izumi.taku@jp.fujitsu.com>
> -----Original Message-----
> From: linux-pci-owner@vger.kernel.org [mailto:linux-pci-owner@vger.kernel.org] On Behalf Of Yinghai Lu
> Sent: Wednesday, October 31, 2012 2:43 AM
> To: Bjorn Helgaas; Len Brown; Taku Izumi; Jiang Liu
> Cc: linux-pci@vger.kernel.org; linux-acpi@vger.kernel.org; Yinghai Lu
> Subject:
>
> Subject: [PATCH resend 0/8] PCI, ACPI, x86: pci root bus hotplug support resources assign and remove path
>
> 1. add support for assign resource for hot add path.
> 2. stop and remove root bus during acpi root remove.
>
>
> could get from
> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci-root-bus-hotplug
>
> Yinghai Lu (8):
> PCI: Separate out pci_assign_unassigned_bus_resources()
> PCI: Move pci_rescan_bus() back to probe.c
> PCI: Move out pci_enable_bridges out of assign_unsigned_bus_res
> PCI, ACPI: assign unassigned resource for hot add root bus
> PCI: Add pci_stop/remove_root_bus()
> PCI, ACPI: Make acpi_pci_root_remove stop/remove pci root bus
> PCI, ACPI: delete root bus prt during hot remove path
> PCI, ACPI: remove acpi_root_driver in reserse order
>
> drivers/acpi/pci_root.c | 21 ++++++++++++++++++++-
> drivers/pci/probe.c | 22 ++++++++++++++++++++++
> drivers/pci/remove.c | 36 ++++++++++++++++++++++++++++++++++++
> drivers/pci/setup-bus.c | 22 +---------------------
> include/linux/pci.h | 3 +++
> 5 files changed, 82 insertions(+), 22 deletions(-)
>
> --
> 1.7.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
2013-12-21 16:48 (unknown), Alex Barattini
@ 2013-12-23 1:44 ` Aaron Lu
2013-12-23 16:24 ` Re: Alex Barattini
0 siblings, 1 reply; 21+ messages in thread
From: Aaron Lu @ 2013-12-23 1:44 UTC (permalink / raw)
To: Alex Barattini, linux-acpi
On 12/22/2013 12:48 AM, Alex Barattini wrote:
> [1.] One line summary of the problem:
>
> 8086:0166 [Dell Inspiron 15R 5521] Impossible to adjust the screen backlight
>
> [2.] Full description of the problem/report:
>
> The change in the level of illumination of the screen, through the
> corresponding option in the control panel, has no effect.
Does this patch help?
http://www.spinics.net/lists/linux-acpi/msg47755.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
2013-12-23 1:44 ` Aaron Lu
@ 2013-12-23 16:24 ` Alex Barattini
0 siblings, 0 replies; 21+ messages in thread
From: Alex Barattini @ 2013-12-23 16:24 UTC (permalink / raw)
To: Aaron Lu; +Cc: linux-acpi
At the moment, set acpi_backlight=vendor on GRUB as a workaround,
works only with kernel version 3.11.0-14-generic (Ubuntu stable
kernel).
Set the workaround in the Kernel v3.13-rc5 produce blackscreen at startup.
You can see the update and the evolution of the bug here:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1261853
2013/12/23 Aaron Lu <aaron.lu@intel.com>:
> On 12/22/2013 12:48 AM, Alex Barattini wrote:
>> [1.] One line summary of the problem:
>>
>> 8086:0166 [Dell Inspiron 15R 5521] Impossible to adjust the screen backlight
>>
>> [2.] Full description of the problem/report:
>>
>> The change in the level of illumination of the screen, through the
>> corresponding option in the control panel, has no effect.
>
> Does this patch help?
> http://www.spinics.net/lists/linux-acpi/msg47755.html
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* RE:
@ 2017-02-23 15:09 Qin's Yanjun
0 siblings, 0 replies; 21+ messages in thread
From: Qin's Yanjun @ 2017-02-23 15:09 UTC (permalink / raw)
How are you today and your family? I require your attention and honest
co-operation about some issues which i will really want to discuss with you
which. Looking forward to read from you soon.
Qin's
______________________________
Sky Silk, http://aknet.kz
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
@ 2017-05-03 6:23 H.A
0 siblings, 0 replies; 21+ messages in thread
From: H.A @ 2017-05-03 6:23 UTC (permalink / raw)
To: Recipients
With profound love in my heart, I Kindly Oblige your interest to very important proposal.. It is Truly Divine and require your utmost attention..........
S hlubokou láskou v mém srdci, Laskave jsem prinutit svuj zájem k návrhu .. Je velmi duležité, skutecne Divine a vyžadují vaši nejvyšší pozornost.
Kontaktujte me prímo pres: helenaroberts99@gmail.com pro úplné podrobnosti.complete.
HELINA .A ROBERTS
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
@ 2017-11-13 14:55 Amos Kalonzo
0 siblings, 0 replies; 21+ messages in thread
From: Amos Kalonzo @ 2017-11-13 14:55 UTC (permalink / raw)
Attn:
I am wondering why You haven't respond to my email for some days now.
reference to my client's contract balance payment of (11.7M,USD)
Kindly get back to me for more details.
Best Regards
Amos Kalonzo
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re:
[not found] ` <163588780885.2993099.2088131017920983969@swboyd.mtv.corp.google.com>
@ 2021-11-25 15:01 ` Hans de Goede
0 siblings, 0 replies; 21+ messages in thread
From: Hans de Goede @ 2021-11-25 15:01 UTC (permalink / raw)
To: Stephen Boyd, Andy Shevchenko, Daniel Scally, Laurent Pinchart,
Liam Girdwood, Mark Brown, Mark Gross, Mauro Carvalho Chehab,
Michael Turquette, Mika Westerberg, Rafael J.Wysocki,
Wolfram Sang
Cc: Len Brown, linux-acpi, platform-driver-x86, linux-kernel,
linux-i2c, Sakari Ailus, Kate Hsuan, linux-media, linux-clk
Hi,
On 11/2/21 22:16, Stephen Boyd wrote:
> Quoting Hans de Goede (2021-11-02 02:49:01)
>> diff --git a/drivers/clk/clk-tps68470.c b/drivers/clk/clk-tps68470.c
>> new file mode 100644
>> index 000000000000..2ad0ac2f4096
>> --- /dev/null
>> +++ b/drivers/clk/clk-tps68470.c
>> @@ -0,0 +1,257 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Clock driver for TPS68470 PMIC
>> + *
>> + * Copyright (c) 2021 Red Hat Inc.
>> + * Copyright (C) 2018 Intel Corporation
>> + *
>> + * Authors:
>> + * Hans de Goede <hdegoede@redhat.com>
>> + * Zaikuo Wang <zaikuo.wang@intel.com>
>> + * Tianshu Qiu <tian.shu.qiu@intel.com>
>> + * Jian Xu Zheng <jian.xu.zheng@intel.com>
>> + * Yuning Pu <yuning.pu@intel.com>
>> + * Antti Laakso <antti.laakso@intel.com>
>> + */
>> +
>> +#include <linux/clk-provider.h>
>> +#include <linux/clkdev.h>
>> +#include <linux/kernel.h>
>> +#include <linux/mfd/tps68470.h>
>> +#include <linux/module.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/platform_data/tps68470.h>
>> +#include <linux/regmap.h>
>> +
>> +#define TPS68470_CLK_NAME "tps68470-clk"
>> +
>> +#define to_tps68470_clkdata(clkd) \
>> + container_of(clkd, struct tps68470_clkdata, clkout_hw)
>> +
> [...]
>> +
>> +static int tps68470_clk_set_rate(struct clk_hw *hw, unsigned long rate,
>> + unsigned long parent_rate)
>> +{
>> + struct tps68470_clkdata *clkdata = to_tps68470_clkdata(hw);
>> + unsigned int idx = tps68470_clk_cfg_lookup(rate);
>> +
>> + if (rate != clk_freqs[idx].freq)
>> + return -EINVAL;
>> +
>> + clkdata->clk_cfg_idx = idx;
>
> It deserves a comment that set_rate can only be called when the clk is
> gated. We have CLK_SET_RATE_GATE flag as well that should be set if the
> clk can't support changing rate while enabled. With that flag set, this
> function should be able to actually change hardware with the assumption
> that the framework won't call down into this clk_op when the clk is
> enabled.
Ok for v6 I've added the CLK_SET_RATE_GATE flag + a comment why
it used and moved the divider programming to tps68470_clk_set_rate()m
while keeping the PLL_EN + output-enable writes in tps68470_clk_prepare()
>
>> +
>> + return 0;
>> +}
>> +
>> +static const struct clk_ops tps68470_clk_ops = {
>> + .is_prepared = tps68470_clk_is_prepared,
>> + .prepare = tps68470_clk_prepare,
>> + .unprepare = tps68470_clk_unprepare,
>> + .recalc_rate = tps68470_clk_recalc_rate,
>> + .round_rate = tps68470_clk_round_rate,
>> + .set_rate = tps68470_clk_set_rate,
>> +};
>> +
>> +static const struct clk_init_data tps68470_clk_initdata = {
>
> Is there a reason to make this a static global? It's probably better to
> throw it on the stack so that a structure isn't sitting around after
> driver probe being unused.
Fixed for v6.
Thanks & Regards,
Hans
>
>> + .name = TPS68470_CLK_NAME,
>> + .ops = &tps68470_clk_ops,
>> +};
>
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2021-11-25 15:03 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-19 4:53 Mj
-- strict thread matches above, loose matches on Subject: below --
2021-11-02 9:48 [PATCH v5 00/11] Add support for X86/ACPI camera sensor/PMIC setup with clk and regulator platform data Hans de Goede
2021-11-02 9:49 ` [PATCH v5 05/11] clk: Introduce clk-tps68470 driver Hans de Goede
[not found] ` <163588780885.2993099.2088131017920983969@swboyd.mtv.corp.google.com>
2021-11-25 15:01 ` Hans de Goede
2017-11-13 14:55 Re: Amos Kalonzo
2017-05-03 6:23 Re: H.A
2017-02-23 15:09 Qin's Yanjun
2013-12-21 16:48 (unknown), Alex Barattini
2013-12-23 1:44 ` Aaron Lu
2013-12-23 16:24 ` Re: Alex Barattini
2012-10-30 4:02 [PATCH v3 7/8] ACPI, PCI: add hostbridge removal function Bjorn Helgaas
2012-10-30 17:42 ` (unknown), Yinghai Lu
2012-11-02 0:17 ` Rafael J. Wysocki
2012-11-05 22:27 ` Re: Bjorn Helgaas
2012-11-05 22:49 ` Re: Yinghai Lu
2012-11-06 5:03 ` Taku Izumi
2011-05-01 13:35 lotto
2010-09-28 12:23 Re: Marc Ferland
2010-07-17 2:41 Re: SINOPEC OIL AND GAS COMPANY
2010-06-05 3:47 MR PETER LUK
2010-04-02 23:17 RE; Mrs Claire page
2005-11-15 9:20 yuki
2005-07-05 23:28 Re: =?ISO-2022-JP?B?GyRCJCpKdSU1ITwlQRsoQiA8b3Rha2FyYWdldHRlckB5YWhvby5jb20+?=
2004-07-19 7:29 Re: Mj
[not found] <200402040504.i1454nSA026612@dcs-server4.cs.uiuc.edu>
[not found] ` <200402040504.i1454nSA026612-X7uhcDA/9l0r6e4dAyNacUYNSvWw4lR0@public.gmane.org>
2004-02-04 5:04 ` Re: Design Patterns Source reflector
2003-01-03 8:43 Re: hotdi-049YEbzBPRy2DcrEJY9i8Q
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).