From: Jeff Moyer <jmoyer@redhat.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
Linda Knippers <linda.knippers@hpe.com>
Subject: Re: [RESEND PATCH v2] acpi/nfit: Fix memory corruption/Unregister mce decoder on failure
Date: Thu, 25 May 2017 10:59:09 -0400 [thread overview]
Message-ID: <x4960gpdltu.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1495714243-5595-1-git-send-email-prarit@redhat.com> (Prarit Bhargava's message of "Thu, 25 May 2017 08:10:43 -0400")
Prarit Bhargava <prarit@redhat.com> writes:
> I somehow managed to trim off the cc list ... oops. Sorry about that.
>
> P.
>
> ----8<----
>
> nfit_init() calls nfit_mce_register() on module load. When the module
> load fails the nfit mce decoder is not unregistered. The module's
> memory is freed leaving the decoder chain referencing junk. This will
> cause panics as future registrations will reference the free'd memory.
>
> Unregister the nfit mce decoder on module init failure.
>
> [v2]: register and then unregister mce handler to avoid losing mce events
>
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Looks good to me.
Acked-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2017-05-25 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 12:10 [RESEND PATCH v2] acpi/nfit: Fix memory corruption/Unregister mce decoder on failure Prarit Bhargava
2017-05-25 14:59 ` Jeff Moyer [this message]
2017-05-25 19:00 ` Vishal Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x4960gpdltu.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=joeyli.kernel@gmail.com \
--cc=lenb@kernel.org \
--cc=linda.knippers@hpe.com \
--cc=linux-acpi@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).