From: Jeff Moyer <jmoyer@redhat.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: linux-nvdimm@ml01.01.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/3] acpi: add a utility function for evaluating _FIT
Date: Fri, 09 Oct 2015 13:28:45 -0400 [thread overview]
Message-ID: <x497fmwj6ia.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1444254577-23744-3-git-send-email-vishal.l.verma@intel.com> (Vishal Verma's message of "Wed, 7 Oct 2015 15:49:36 -0600")
Vishal Verma <vishal.l.verma@intel.com> writes:
> /**
> + * acpi_evaluate_fit: Evaluate _FIT method to get an updated NFIT
> + * @handle: ACPI device handle
> + * @buf: buffer for the updated NFIT
> + *
> + * Evaluate device's _FIT method if present to get an updated NFIT
> + */
> +acpi_status acpi_evaluate_fit(acpi_handle handle, struct acpi_buffer **buf)
> +{
> + acpi_status status;
> + struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> +
> + status = acpi_evaluate_object(handle, "_FIT", NULL, &buffer);
> +
> + if (ACPI_FAILURE(status))
> + return status;
> +
> + *buf = &buffer;
Umm, unless I'm missing something, you're returning a stack address.
-Jeff
next prev parent reply other threads:[~2015-10-09 17:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 21:49 [PATCH 0/3] Hotplug support for libnvdimm Vishal Verma
2015-10-07 21:49 ` [PATCH 1/3] nfit: in acpi_nfit_init, break on a 0-length table Vishal Verma
2015-10-09 17:23 ` Jeff Moyer
2015-10-09 17:27 ` Dan Williams
2015-10-09 17:51 ` Verma, Vishal L
2015-10-07 21:49 ` [PATCH 2/3] acpi: add a utility function for evaluating _FIT Vishal Verma
2015-10-09 17:28 ` Jeff Moyer [this message]
2015-10-09 17:54 ` Verma, Vishal L
2015-10-09 17:56 ` Dan Williams
2015-10-09 21:14 ` Rafael J. Wysocki
2015-10-07 21:49 ` [PATCH 3/3] acpi: nfit: Add support for hotplug Vishal Verma
2015-10-09 17:33 ` Jeff Moyer
2015-10-09 18:08 ` Verma, Vishal L
2015-10-09 18:13 ` Dan Williams
2015-10-09 19:44 ` Dan Williams
2015-10-13 0:35 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x497fmwj6ia.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=rafael.j.wysocki@intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).