Re: [DMESG] cpumask_t in action

[Jes Sorensen <jes-dtAfj9ClZIwnoBwkMbRkTB2eb7JE58TQ@public.gmane.org>]

>>>>> "Matthew" == Matthew Wilcox <willy-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org> writes:

Matthew> On Wed, Nov 05, 2003 at 02:22:02PM -0800, Jesse Barnes wrote:

Matthew> There's a number of things here that annoy me.  One is the
Matthew> stupid "Processor 8192/1 is spinning up".  I would expect
Matthew> "Processor 2/96 is spinning up", but why have this line at
Matthew> all?  I'd also like to see "Bringing up 3", "Processor 1 has
Matthew> spun up..." and "CPU 1 IS NOW UP!" go away.  That'd cut us
Matthew> down to:

>> CPU 3: 61 virtual and 50 physical address bits CPU 3: nasid 2,
>> slice 2, cnode 1 CPU 3: base freq=200.000MHz, ITC ratio=15/2, ITC
>> freq=1500.000MHz+/--1ppm Calibrating delay loop... 2241.08 BogoMIPS
>> CPU3: CPU has booted.  Starting migration thread for cpu 3

Matthew> A 40% reduction in per-cpu verbosity ;-)

Why not turn it the other way and just report the success of booted
CPUs and more detailed results for the CPUs that failed? I know there
are cases where you want the debug info in case of tracking kernel
bugs, but one could stick a compile time debug flag into the code for
that case, 960 - 40% = 576 lines of guff is still way too much IMHO,
especially over a serial console.

Cheers,
Jes


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/