From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B68C91C4A34 for ; Fri, 20 Dec 2024 11:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734695179; cv=none; b=KqaDUGCSWHqSTIkI3Zo2Gjd0g2xoRFBNVqV9RHL/PFJo3VGxzdUyeU7g5R2Lsqzpy7irEkJl11QrPn2H4gp+jBaePbt6Xhiz8s+yoAVHMMHpPlc3c5a9XIOiSgEv1bvKfrnxrLY9N/0z4FFksxletLobONtkqoiiaJZnsLhr1nA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734695179; c=relaxed/simple; bh=yIScTezDLLIu5IKi/+u7+E2INdxlbVe48yxybU1XCOs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NaCL5bYCu59kQG5A45mGqgyHO7rNnPK04F1MZeVKm7NBpRcF4WIloUlUIrh42Id3vENFfq8QHe2G7Wge+eHC6XOGzDUySggPNTjbG5uqt+BjsexQ7bxhVNInZNJBKkL9hoRccWpVGW50dyUxYGDpDeRq4cdyEstw14nr447Bw0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=A1F34s7h; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="A1F34s7h" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2165448243fso19063015ad.1 for ; Fri, 20 Dec 2024 03:46:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734695175; x=1735299975; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mBRlMffFmN+hz5HGm/qsvwuPzuwmJovQ60y3/xe1EoY=; b=A1F34s7haE1BNX3nHh73oZcFwT07QCSwjomd6/prukB2miCl02nDVDRm+mvi3NM5V8 ClabG/pQNIVwt6uCindT8wbcyTlPyUI5QrR1NRgnzZIAehUFN/y5fdV5eQpYEmu5xHzT VEzkx9kR/0zHRixLyDzZpZnT5SNKotPRLR4to7UlrupYY49iNH7HEhkrUr+g4nR1b3Co RtNHp9Qe7JDoBSqjnYCgWYyUyA9JoFBxhAYT+7/Y4i/cENy+6hc3FtXU1lBho1pPSO4R a96yUFBguasrJZzM06Bksb3cvVjB9+KIkLM3GSURJv4mJPNiHQr3JfTYyrL9bY7Sld1r LY/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734695175; x=1735299975; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mBRlMffFmN+hz5HGm/qsvwuPzuwmJovQ60y3/xe1EoY=; b=EG8p9BmKRJS8wUXTJcEbHsgeGZLuzzVf+Wc/d6bgJNTQdodzfwnLxLX8CKT+6fvjHj LTfdQkWcvDI+XQMWyMYvnb1/sPRuzTO8wAhDrG9SDQse7kZEo6SzLj9PZqoZQAuVMmIm elJlctNMoO0lCmgXToaoWbRNvZ6B5ZrmVbde04jm+l4YwYxIEQ2w7LBLj1Km1v4OwFgx jvMYOnB6G67J4FDrTl/kFnuvs+87guEv74bA3CPKXf6LyrFjhOEoAXCP2enIhEOuQmA9 IlUZtKpH+hW1DUr6yl00iY8x8gweqfljEWCiKvmd1Gdve8gQESgeI6EBprg4x07+yyPP hyiw== X-Forwarded-Encrypted: i=1; AJvYcCW0YcusqnKFVCC8hPQpK394NP0268TZJW4jmyuQ72pgaTDA4vDgeO59sdTyLG465UrPMuBjf3NuGLAH6A==@vger.kernel.org X-Gm-Message-State: AOJu0YwXr+dD4B+KU5OktTDufuX/ixbipmTZZ6DyeMFkB2f/WFUvPnEy +sMAzvrAjKRSjV795Y5nvDNSTRDrQsav52diSbTZ5vktjos60dOw0ugMP1rGS1Y= X-Gm-Gg: ASbGncs/YHHbUBuXow46/j+qNcQQJj0RXfq7I5enNZ/eWp81fY/5RFqnIqggGu2JUWs hwnpF213VnodnN2OO1AN4UpoBXblNhSBy2lEaUPw1IS6vo8m3/RmDFp9CjKMlC+aGQA9M4Tt5TF IzWTNtAghkujD6Ws4C4tUW7B4i5Ev1KTgqU8GaiLTILzFK7Mml/PMeHaVo1mlp5TSI7TWAa2bpo 8tD5lMP3O+5vjCseT5+SjQ/SCionZluYbb2nO/LqqPjKfPQXoNpfsoLANPCNmxHMDAbTFEssjxP uKeMe/i/SwzNpt5plYZ16Yl7K4/5qrnlfrNSp+IxDlb8sQfU72G2abo= X-Google-Smtp-Source: AGHT+IG40UPaAgLiyyOp9k8XqW2vPy2P2eyTWxZSuqMQTAARXLtkQgcz7lH63J8oRPI229SK+RLglg== X-Received: by 2002:a17:902:ce92:b0:216:4169:f9d7 with SMTP id d9443c01a7336-219e6e8bc7cmr41107195ad.2.1734695174995; Fri, 20 Dec 2024 03:46:14 -0800 (PST) Received: from ?IPV6:2409:8a28:f44:3764:680a:144b:d927:5a3b? ([2409:8a28:f44:3764:680a:144b:d927:5a3b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2db9939b5sm5267286a91.1.2024.12.20.03.46.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 03:46:14 -0800 (PST) Message-ID: <0daabd32-cba4-4345-baa8-e8c66bc899ff@bytedance.com> Date: Fri, 20 Dec 2024 19:46:04 +0800 Precedence: bulk X-Mailing-List: linux-alpha@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers Content-Language: en-US To: Kevin Brodsky Cc: Peter Zijlstra , linux-mm@kvack.org, Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org, Alexander Gordeev References: <20241219164425.2277022-1-kevin.brodsky@arm.com> <20241219164425.2277022-2-kevin.brodsky@arm.com> <20241219171920.GB26279@noisy.programming.kicks-ass.net> <75cb4ff8-eb0c-4519-a30a-f8be717ba278@arm.com> From: Qi Zheng In-Reply-To: <75cb4ff8-eb0c-4519-a30a-f8be717ba278@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Kevin, On 2024/12/20 18:49, Kevin Brodsky wrote: > Hi Peter, Qi, > > On 19/12/2024 18:19, Peter Zijlstra wrote: >> On Thu, Dec 19, 2024 at 04:44:16PM +0000, Kevin Brodsky wrote: >>> Besides the ptlock management at PTE/PMD level, all the >>> pagetable_*_[cd]tor have the same implementation. Introduce common >>> helpers for all levels to reduce the duplication. >> Uff, I forgot to Cc you on the discussion here, sorry!: >> >> https://lkml.kernel.org/r/cover.1734526570.git.zhengqi.arch@bytedance.com >> >> we now have two series doing more or less overlapping things :/ >> >> You can in fact trivially merge the all the implementations -- the >> apparent non-common bit (ptlock_free) is a no-op for all those other >> levels because they'll be having ptdesc->lock == NULL. > > Ah that is good to know, thanks for letting me know about that and Qi's > series! Fortunately there isn't that much overlap between our series - I > think we can easily sort this out. > > Qi, shall we collaborate to make our series complementary? I believe my > series covers patch 2 and 4 of your series, but it goes further by > covering all levels and all architectures, and patches introducing > ctor/dtor are already split as Alexander suggested on your series. So my > suggestion would be: > > * Remove patch 1 in my series - I'd just introduce > pagetable_{p4d,pgd}_[cd]tor with the same implementation as > pagetable_pud_[cd]tor. > * Remove patch 2 and 4 from your series and rebase it on mine. I quickly went through your patch series. It looks like my patch 2 and your patch 6 are duplicated, so you want me to remove my patch 2. But I think you may not be able to simple let arm64, riscv and x86 to use generic p4d_{alloc_one,free}(). Because even if CONFIG_PGTABLE_LEVELS > 4, the pgtable_l5_enabled() may not be true. For example, in arm64: #if CONFIG_PGTABLE_LEVELS > 4 static __always_inline bool pgtable_l5_enabled(void) { if (!alternative_has_cap_likely(ARM64_ALWAYS_BOOT)) return vabits_actual == VA_BITS; return alternative_has_cap_unlikely(ARM64_HAS_VA52); } Did I miss something? My patch series is not only for cleanup, but also for fixes of UAF issue [1], so is it possible to rebase your patch series onto mine? I can post v3 ASAP. [1]. https://lore.kernel.org/all/67548279.050a0220.a30f1.015b.GAE@google.com/ Thanks! > > Let me know if that makes sense, if so I'll post a v2. > > Cheers, > - Kevin