From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: dl8bcu@dl8bcu.de, rth@twiddle.net, linux-scsi@vger.kernel.org,
linux-alpha@vger.kernel.org
Subject: Re: Build error: `.exit.text' referenced in section `.rodata'
Date: Tue, 13 May 2008 09:59:17 -0500 [thread overview]
Message-ID: <1210690758.3077.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20080513143112.GA21274@jurassic.park.msu.ru>
On Tue, 2008-05-13 at 18:31 +0400, Ivan Kokshaysky wrote:
> On Mon, May 12, 2008 at 09:01:44AM -0500, James Bottomley wrote:
> > > With gcc 4.2.3 I get the same error. The noinline patch fixes it again.
> > >
> > > text data bss dec hex filename
> > > 6721720 624416 397508 7743644 76289c vmlinux-gcc-4.2.3
> >
> > OK, so it's an unfixed bug in gcc, and it looks to be specific to the
> > alpha backend.
>
> No, other architectures are just lucky that the compiler decides
> a) not to generate a jump table for switch statement in sd_major() and/or
> b) not to inline this function.
>
> I have a similar test case that fails on x86 as well.
But if that's true then the whole basis for our section based discards
is bogus, because the statement generating the jump table could be
inside the actual function body instead of being inlined, so if it's
failing on x86 as well, we likely need it fixed there too.
> > if the compiler chooses to inline a function, it has to
> > respect the sectional (and other constraints) of the outer function.
> > Can someone file a bug report with the relevant compiler people?
>
> It would be good, but in the meantime the 'noinline' fix seems to be
> a most sensible option...
We can certainly add it as a short term option. However, given the push
in certain quarters to make even more use of sections as a means of
discarding code, we're going to have to ask someone to fix the compiler.
James
next prev parent reply other threads:[~2008-05-13 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 15:19 Build error: `.exit.text' referenced in section `.rodata' Thorsten Kranzkowski
2008-05-11 16:55 ` James Bottomley
2008-05-11 19:20 ` Thorsten Kranzkowski
2008-05-12 11:52 ` Thorsten Kranzkowski
2008-05-12 14:01 ` James Bottomley
2008-05-13 14:31 ` Ivan Kokshaysky
2008-05-13 14:59 ` James Bottomley [this message]
2008-05-13 20:06 ` Ivan Kokshaysky
2008-05-13 20:51 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210690758.3077.23.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=dl8bcu@dl8bcu.de \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).