* [PATCH RFT linux-next] alpha: dma-mapping: support debug_dma_mapping_error @ 2012-10-26 16:32 Shuah Khan 2012-11-15 17:49 ` Shuah Khan 0 siblings, 1 reply; 5+ messages in thread From: Shuah Khan @ 2012-10-26 16:32 UTC (permalink / raw) To: rth, ink, mattst88, kyungmin.park, m.szyprowski, arnd, andrzej.p Cc: linux-alpha, LKML, shuahkhan Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated. Signed-off-by: Shuah Khan <shuah.khan@hp.com> --- arch/alpha/include/asm/dma-mapping.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/alpha/include/asm/dma-mapping.h b/arch/alpha/include/asm/dma-mapping.h index dfa32f0..b4d483b 100644 --- a/arch/alpha/include/asm/dma-mapping.h +++ b/arch/alpha/include/asm/dma-mapping.h @@ -32,6 +32,7 @@ static inline void dma_free_attrs(struct device *dev, size_t size, static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) { + debug_dma_mapping_error(dev, dma_addr); return get_dma_ops(dev)->mapping_error(dev, dma_addr); } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RFT linux-next] alpha: dma-mapping: support debug_dma_mapping_error 2012-10-26 16:32 [PATCH RFT linux-next] alpha: dma-mapping: support debug_dma_mapping_error Shuah Khan @ 2012-11-15 17:49 ` Shuah Khan 2013-03-27 6:59 ` Michael Cree 0 siblings, 1 reply; 5+ messages in thread From: Shuah Khan @ 2012-11-15 17:49 UTC (permalink / raw) To: rth, m.szyprowski Cc: ink, mattst88, kyungmin.park, arnd, andrzej.p, linux-alpha, LKML, shuahkhan On Fri, 2012-10-26 at 10:32 -0600, Shuah Khan wrote: > Add support for debug_dma_mapping_error() call to avoid warning from > debug_dma_unmap() interface when it checks for mapping error checked > status. Without this patch, device driver failed to check map error > warning is generated. > > Signed-off-by: Shuah Khan <shuah.khan@hp.com> > --- > arch/alpha/include/asm/dma-mapping.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/alpha/include/asm/dma-mapping.h b/arch/alpha/include/asm/dma-mapping.h > index dfa32f0..b4d483b 100644 > --- a/arch/alpha/include/asm/dma-mapping.h > +++ b/arch/alpha/include/asm/dma-mapping.h > @@ -32,6 +32,7 @@ static inline void dma_free_attrs(struct device *dev, size_t size, > > static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) > { > + debug_dma_mapping_error(dev, dma_addr); > return get_dma_ops(dev)->mapping_error(dev, dma_addr); > } > Marek, This is for alpha to go through your tree. -- Shuah ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RFT linux-next] alpha: dma-mapping: support debug_dma_mapping_error 2012-11-15 17:49 ` Shuah Khan @ 2013-03-27 6:59 ` Michael Cree 2013-03-27 15:45 ` Marek Szyprowski 0 siblings, 1 reply; 5+ messages in thread From: Michael Cree @ 2013-03-27 6:59 UTC (permalink / raw) To: Shuah Khan Cc: rth, m.szyprowski, ink, mattst88, kyungmin.park, arnd, andrzej.p, linux-alpha, LKML, shuahkhan On Thu, Nov 15, 2012 at 10:49:28AM -0700, Shuah Khan wrote: > On Fri, 2012-10-26 at 10:32 -0600, Shuah Khan wrote: > > Add support for debug_dma_mapping_error() call to avoid warning from > > debug_dma_unmap() interface when it checks for mapping error checked > > status. Without this patch, device driver failed to check map error > > warning is generated. > > > > Signed-off-by: Shuah Khan <shuah.khan@hp.com> > > --- > > arch/alpha/include/asm/dma-mapping.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/alpha/include/asm/dma-mapping.h b/arch/alpha/include/asm/dma-mapping.h > > index dfa32f0..b4d483b 100644 > > --- a/arch/alpha/include/asm/dma-mapping.h > > +++ b/arch/alpha/include/asm/dma-mapping.h > > @@ -32,6 +32,7 @@ static inline void dma_free_attrs(struct device *dev, size_t size, > > > > static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) > > { > > + debug_dma_mapping_error(dev, dma_addr); > > return get_dma_ops(dev)->mapping_error(dev, dma_addr); > > } > > > > Marek, > > This is for alpha to go through your tree. Given that this does not appear to be upstream yet I'll take it through the Alpha tree. Cheers Michael. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RFT linux-next] alpha: dma-mapping: support debug_dma_mapping_error 2013-03-27 6:59 ` Michael Cree @ 2013-03-27 15:45 ` Marek Szyprowski 2013-03-27 16:18 ` Shuah Khan 0 siblings, 1 reply; 5+ messages in thread From: Marek Szyprowski @ 2013-03-27 15:45 UTC (permalink / raw) To: Michael Cree, Shuah Khan, rth, ink, mattst88, kyungmin.park, arnd, andrzej.p, linux-alpha, LKML, shuahkhan Hello, On 3/27/2013 7:59 AM, Michael Cree wrote: > On Thu, Nov 15, 2012 at 10:49:28AM -0700, Shuah Khan wrote: > > On Fri, 2012-10-26 at 10:32 -0600, Shuah Khan wrote: > > > Add support for debug_dma_mapping_error() call to avoid warning from > > > debug_dma_unmap() interface when it checks for mapping error checked > > > status. Without this patch, device driver failed to check map error > > > warning is generated. > > > > > > Signed-off-by: Shuah Khan <shuah.khan@hp.com> > > > --- > > > arch/alpha/include/asm/dma-mapping.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/alpha/include/asm/dma-mapping.h b/arch/alpha/include/asm/dma-mapping.h > > > index dfa32f0..b4d483b 100644 > > > --- a/arch/alpha/include/asm/dma-mapping.h > > > +++ b/arch/alpha/include/asm/dma-mapping.h > > > @@ -32,6 +32,7 @@ static inline void dma_free_attrs(struct device *dev, size_t size, > > > > > > static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) > > > { > > > + debug_dma_mapping_error(dev, dma_addr); > > > return get_dma_ops(dev)->mapping_error(dev, dma_addr); > > > } > > > > > > > Marek, > > > > This is for alpha to go through your tree. > > Given that this does not appear to be upstream yet I'll take it through > the Alpha tree. Those patches in the end went via IOMMU tree. I looks that the patch for Alpha has been missed. It looks that this patch should be merged to v3.9-rcX asap to fix the broken dma-mapping api calls. Best regards -- Marek Szyprowski Samsung Poland R&D Center ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RFT linux-next] alpha: dma-mapping: support debug_dma_mapping_error 2013-03-27 15:45 ` Marek Szyprowski @ 2013-03-27 16:18 ` Shuah Khan 0 siblings, 0 replies; 5+ messages in thread From: Shuah Khan @ 2013-03-27 16:18 UTC (permalink / raw) To: Marek Szyprowski Cc: Michael Cree, rth, ink, mattst88, kyungmin.park, arnd, andrzej.p, linux-alpha, LKML, Shuah Khan On Wed, 2013-03-27 at 16:45 +0100, Marek Szyprowski wrote: > Hello, > > On 3/27/2013 7:59 AM, Michael Cree wrote: > > On Thu, Nov 15, 2012 at 10:49:28AM -0700, Shuah Khan wrote: > > > On Fri, 2012-10-26 at 10:32 -0600, Shuah Khan wrote: > > > > Add support for debug_dma_mapping_error() call to avoid warning from > > > > debug_dma_unmap() interface when it checks for mapping error checked > > > > status. Without this patch, device driver failed to check map error > > > > warning is generated. > > > > > > > > Signed-off-by: Shuah Khan <shuah.khan@hp.com> > > > > --- > > > > arch/alpha/include/asm/dma-mapping.h | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/alpha/include/asm/dma-mapping.h b/arch/alpha/include/asm/dma-mapping.h > > > > index dfa32f0..b4d483b 100644 > > > > --- a/arch/alpha/include/asm/dma-mapping.h > > > > +++ b/arch/alpha/include/asm/dma-mapping.h > > > > @@ -32,6 +32,7 @@ static inline void dma_free_attrs(struct device *dev, size_t size, > > > > > > > > static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) > > > > { > > > > + debug_dma_mapping_error(dev, dma_addr); > > > > return get_dma_ops(dev)->mapping_error(dev, dma_addr); > > > > } > > > > > > > > > > Marek, > > > > > > This is for alpha to go through your tree. > > > > Given that this does not appear to be upstream yet I'll take it through > > the Alpha tree. > > Those patches in the end went via IOMMU tree. I looks that the patch for > Alpha has > been missed. It looks that this patch should be merged to v3.9-rcX asap > to fix the > broken dma-mapping api calls. > The reason it didn't get pulled into iommu tree was that alpha Kconfig doesn't support HAVE_DMA_API_DEBUG and DMA_API_DEBUG. I don't see it in arch/alpha/Kconfig. That said, this patch is needed on alpha, if these two config options get enabled. I will leave it up to the alpha maintainers to decide if this patch is needed or not. thanks, -- Shuah ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-03-27 16:18 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-10-26 16:32 [PATCH RFT linux-next] alpha: dma-mapping: support debug_dma_mapping_error Shuah Khan 2012-11-15 17:49 ` Shuah Khan 2013-03-27 6:59 ` Michael Cree 2013-03-27 15:45 ` Marek Szyprowski 2013-03-27 16:18 ` Shuah Khan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).