Alpha arch development list
 help / color / mirror / Atom feed
From: rct@gherkin.frus.com (Bob Tracy)
To: Hugh Dickins <hugh@veritas.com>
Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org
Subject: Re: 2.6.22-rc6 bad page error
Date: Mon, 9 Jul 2007 13:53:24 -0500 (CDT)	[thread overview]
Message-ID: <20070709185324.387ACDBA1@gherkin.frus.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0707071852240.12481@blonde.wat.veritas.com> "from Hugh Dickins at Jul 7, 2007 07:38:58 pm"

Hugh Dickins wrote:
> (...) I'm expecting this to be a regression we introduced in
> 2.6.15, rather than recently in 2.6.22 (now, that's better isn't it ;-?)
> (...)
> I think sound/isa/es18xx.c's
> 	snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV,
> will take it to sound/core/memalloc.c's
> 	res = dma_alloc_coherent(dev, PAGE_SIZE << pg, dma, gfp_flags);
> where we've carefully included __GFP_COMP in gfp_flags to avoid this
> kind of problem (replacing the pre-2.6.15 use of PageReserved).
> (...)
> Blame me or Nick for removing the
> special PageReserved usage, or Alpha for ignoring our gfp_flags:
> 
>   #define dma_alloc_coherent(dev, size, addr, gfp)	\
> 		pci_alloc_consistent(alpha_gendev_to_pci(dev), size, addr)
> 
> When you get a chance, please would you try patch below?
> 
> --- 2.6.22-rc7/arch/alpha/kernel/pci_iommu.c	2007-06-05 06:19:19.000000000 +0100
> +++ linux/arch/alpha/kernel/pci_iommu.c	2007-07-07 15:00:04.000000000 +0100

That seems to have done the trick.  Normally, I get the "bad page"
errors on the second NX session, but I'm on the third session of the
day (thus far), and everything seems to be ok as far as I can tell.

-- 
-----------------------------------------------------------------------
Bob Tracy               | "Eagles may soar, but weasels don't get
rct@frus.com            |  sucked into jet engines."       --Anon
-----------------------------------------------------------------------

  parent reply	other threads:[~2007-07-09 18:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070705195835.AAB19DBA1@gherkin.frus.com>
2007-07-07 13:48 ` 2.6.22-rc6 bad page error Michal Piotrowski
2007-07-07 14:56   ` Bob Tracy
2007-07-07 18:38     ` Hugh Dickins
2007-07-08 21:05       ` Bob Tracy
2007-07-09 18:53       ` Bob Tracy [this message]
2007-07-10 20:25         ` Hugh Dickins
2007-07-11 13:02           ` Ivan Kokshaysky
2007-07-11 17:07             ` Hugh Dickins
2007-07-12  9:46               ` Ivan Kokshaysky
2007-07-12 16:13                 ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070709185324.387ACDBA1@gherkin.frus.com \
    --to=rct@gherkin.frus.com \
    --cc=hugh@veritas.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox