From: Andrew Morton <akpm@linux-foundation.org>
To: Cheng Renquan <crquan@gmail.com>
Cc: rth@twiddle.net, linux-alpha@vger.kernel.org,
ink@jurassic.park.msu.ru, viro@zeniv.linux.org.uk,
cr_quan@163.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] do_pipe cleanup: drop its last user in arch/alpha/
Date: Mon, 2 Feb 2009 12:48:22 -0800 [thread overview]
Message-ID: <20090202124822.ed2deb84.akpm@linux-foundation.org> (raw)
In-Reply-To: <1232772231-6523-1-git-send-email-crquan@gmail.com>
On Sat, 24 Jan 2009 12:43:50 +0800
Cheng Renquan <crquan@gmail.com> wrote:
> --- a/arch/alpha/kernel/osf_sys.c
> +++ b/arch/alpha/kernel/osf_sys.c
> @@ -46,7 +46,7 @@
> #include <asm/hwrpb.h>
> #include <asm/processor.h>
>
> -extern int do_pipe(int *);
> +extern int do_pipe_flags(int *, int);
From: Andrew Morton <akpm@linux-foundation.org>
WARNING: externs should be avoided in .c files
#42: FILE: arch/alpha/kernel/osf_sys.c:49:
+extern int do_pipe_flags(int *, int);
total: 0 errors, 1 warnings, 36 lines checked
./patches/do_pipe-drop-its-last-user-in-arch-alpha.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Cheng Renquan <crquan@gmail.com>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Richard Henderson <rth@twiddle.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/alpha/kernel/osf_sys.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -puN arch/alpha/kernel/osf_sys.c~do_pipe-drop-its-last-user-in-arch-alpha-checkpatch-fixes arch/alpha/kernel/osf_sys.c
--- a/arch/alpha/kernel/osf_sys.c~do_pipe-drop-its-last-user-in-arch-alpha-checkpatch-fixes
+++ a/arch/alpha/kernel/osf_sys.c
@@ -14,6 +14,7 @@
#include <linux/sched.h>
#include <linux/kernel.h>
#include <linux/mm.h>
+#include <linux/fs.h>
#include <linux/smp.h>
#include <linux/smp_lock.h>
#include <linux/stddef.h>
@@ -46,8 +47,6 @@
#include <asm/hwrpb.h>
#include <asm/processor.h>
-extern int do_pipe_flags(int *, int);
-
/*
* Brk needs to return an error. Still support Linux's brk(0) query idiom,
* which OSF programs just shouldn't be doing. We're still not quite
_
OK?
next prev parent reply other threads:[~2009-02-02 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 4:43 [PATCH] do_pipe cleanup: drop its last user in arch/alpha/ Cheng Renquan
2009-01-24 4:43 ` [PATCH] add the missing linux alpha port mailling list Cheng Renquan
2009-02-02 20:48 ` Andrew Morton [this message]
[not found] <91b13c310901122126p346aa905g8233ed55ab18f902@mail.gmail.com>
2009-01-14 9:01 ` [PATCH] do_pipe cleanup: drop its last user in arch/alpha/ Cheng Renquan
2009-01-14 9:09 ` Cheng Renquan
2009-01-15 0:19 ` Richard Henderson
2009-01-15 8:00 ` Cheng Renquan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090202124822.ed2deb84.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cr_quan@163.com \
--cc=crquan@gmail.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).