* [patch 2/6] alpha: cpumask_of_node() should handle -1 as a node
[not found] <20100106045509.245662398@samba.org>
@ 2010-01-06 4:55 ` Anton Blanchard
2010-01-14 18:24 ` Matt Turner
0 siblings, 1 reply; 2+ messages in thread
From: Anton Blanchard @ 2010-01-06 4:55 UTC (permalink / raw)
To: Richard Henderson, Ivan Kokshaysky
Cc: linux-alpha, linux-kernel, Rusty Russell, Andrew Morton
pcibus_to_node can return -1 if we cannot determine which node a pci bus
is on. If passed -1, cpumask_of_node will negatively index the lookup array
and pull in random data:
# cat /sys/devices/pci0000:00/0000:00:01.0/local_cpus
00000000,00000003,00000000,00000000
# cat /sys/devices/pci0000:00/0000:00:01.0/local_cpulist
64-65
Change cpumask_of_node to check for -1 and return cpu_all_mask in this
case:
# cat /sys/devices/pci0000:00/0000:00:01.0/local_cpus
ffffffff,ffffffff,ffffffff,ffffffff
# cat /sys/devices/pci0000:00/0000:00:01.0/local_cpulist
0-127
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: linux-cpumask/arch/alpha/include/asm/topology.h
===================================================================
--- linux-cpumask.orig/arch/alpha/include/asm/topology.h 2010-01-06 15:20:22.952583839 +1100
+++ linux-cpumask/arch/alpha/include/asm/topology.h 2010-01-06 15:20:46.610083557 +1100
@@ -28,6 +28,9 @@ static const struct cpumask *cpumask_of_
{
int cpu;
+ if (node == -1)
+ return cpu_all_mask;
+
cpumask_clear(&node_to_cpumask_map[node]);
for_each_online_cpu(cpu) {
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2/6] alpha: cpumask_of_node() should handle -1 as a node
2010-01-06 4:55 ` [patch 2/6] alpha: cpumask_of_node() should handle -1 as a node Anton Blanchard
@ 2010-01-14 18:24 ` Matt Turner
0 siblings, 0 replies; 2+ messages in thread
From: Matt Turner @ 2010-01-14 18:24 UTC (permalink / raw)
To: Anton Blanchard
Cc: Richard Henderson, Ivan Kokshaysky, linux-alpha, linux-kernel,
Rusty Russell, Andrew Morton
On Tue, Jan 5, 2010 at 11:55 PM, Anton Blanchard <anton@samba.org> wrote:
> pcibus_to_node can return -1 if we cannot determine which node a pci bus
> is on. If passed -1, cpumask_of_node will negatively index the lookup array
> and pull in random data:
>
> # cat /sys/devices/pci0000:00/0000:00:01.0/local_cpus
> 00000000,00000003,00000000,00000000
> # cat /sys/devices/pci0000:00/0000:00:01.0/local_cpulist
> 64-65
>
> Change cpumask_of_node to check for -1 and return cpu_all_mask in this
> case:
>
> # cat /sys/devices/pci0000:00/0000:00:01.0/local_cpus
> ffffffff,ffffffff,ffffffff,ffffffff
> # cat /sys/devices/pci0000:00/0000:00:01.0/local_cpulist
> 0-127
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>
> Index: linux-cpumask/arch/alpha/include/asm/topology.h
> ===================================================================
> --- linux-cpumask.orig/arch/alpha/include/asm/topology.h 2010-01-06 15:20:22.952583839 +1100
> +++ linux-cpumask/arch/alpha/include/asm/topology.h 2010-01-06 15:20:46.610083557 +1100
> @@ -28,6 +28,9 @@ static const struct cpumask *cpumask_of_
> {
> int cpu;
>
> + if (node == -1)
> + return cpu_all_mask;
> +
> cpumask_clear(&node_to_cpumask_map[node]);
>
> for_each_online_cpu(cpu) {
>
> --
Thanks! I've added this to alpha-2.6.
Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-14 18:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100106045509.245662398@samba.org>
2010-01-06 4:55 ` [patch 2/6] alpha: cpumask_of_node() should handle -1 as a node Anton Blanchard
2010-01-14 18:24 ` Matt Turner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).