From: Kyle McMartin <kyle@mcmartin.ca>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
"linux-cris-kernel@axis.com" <linux-cris-kernel@axis.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Hirokazu Takata <takata@linux-m32r.org>,
Greg Ungerer <gerg@uclinux.org>, Jeff Dike <jdike@addtoit.com>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
Chris Zankel <chris@zankel.net>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [RFC trollpatch 1/1] genirq: Remove the fits all and nothing __do_IRQ() code
Date: Tue, 28 Sep 2010 20:46:07 -0400 [thread overview]
Message-ID: <20100929004607.GA18362@bombadil.infradead.org> (raw)
In-Reply-To: <987664A83D2D224EAE907B061CE93D530160471328@orsmsx505.amr.corp.intel.com>
On Mon, Sep 27, 2010 at 12:01:51PM -0700, Luck, Tony wrote:
> > Hmm, why isn't chip->unmask() sufficient ?
>
> That's a good question. I'll take a look at what ia64 is doing
> in the ->unmask() and ->end() functions to see if I can fix this
> with some code shuffling.
>
Did you end up solving this? ia64 iosapic and parisc iosapic still look
fairly similar... I hit the same issue of ->end() not being called in
the handle_level_irq path and ended up just folding in the missing bit
to ->unmask (we were already EOI the IOSAPIC, but missing the EOI for
the parisc cpu.)
--Kyle
next prev parent reply other threads:[~2010-09-29 0:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 18:14 [RFC trollpatch 1/1] genirq: Remove the fits all and nothing __do_IRQ() code Thomas Gleixner
2010-09-08 18:51 ` James Bottomley
2010-09-08 19:34 ` Thomas Gleixner
2010-09-08 20:35 ` James Bottomley
2010-09-08 21:35 ` Thomas Gleixner
2010-09-08 20:28 ` Mike Frysinger
2010-09-08 18:58 ` Kyle McMartin
2010-09-08 20:36 ` Luck, Tony
2010-09-09 7:10 ` Mikael Starvik
2010-09-09 13:44 ` Dialup Jon Norstog
2010-09-09 7:21 ` Greg Ungerer
2010-09-09 14:09 ` Kyle McMartin
2010-09-09 23:17 ` Greg Ungerer
2010-09-27 17:36 ` Tony Luck
2010-09-27 18:01 ` Thomas Gleixner
2010-09-27 18:39 ` Luck, Tony
2010-09-27 18:49 ` Thomas Gleixner
2010-09-27 19:01 ` Luck, Tony
2010-09-29 0:46 ` Kyle McMartin [this message]
2010-09-29 4:55 ` Luck, Tony
2010-09-29 14:38 ` Kyle McMartin
2010-09-27 19:48 ` richard -rw- weinberger
2010-09-27 19:54 ` Thomas Gleixner
2010-09-30 1:26 ` Kyle McMartin
2010-09-30 2:41 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929004607.GA18362@bombadil.infradead.org \
--to=kyle@mcmartin.ca \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=gerg@uclinux.org \
--cc=hch@infradead.org \
--cc=jdike@addtoit.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=takata@linux-m32r.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).