From: Jim Faulkner <jfaulkne@ccs.neu.edu>
To: Michael Cree <mcree@orcon.net.nz>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, gregkh@linuxfoundation.org,
rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com,
torvalds@linux-foundation.org, jay.estabrook@gmail.com
Subject: Re: [PATCH] fix modpost when CONFIG_ALPHA_TSUNAMI=y
Date: Sat, 18 Feb 2012 17:39:57 -0500 [thread overview]
Message-ID: <20120218223957.GB28758@alumni-linux.ccs.neu.edu> (raw)
In-Reply-To: <4F40264E.6050602@orcon.net.nz>
On Sun, Feb 19, 2012 at 11:29:34AM +1300, Michael Cree wrote:
> >
> > +#include <linux/module.h>
>
> Wouldn't <linux/exports.h> be better? I seem to recall that this was a
> problem with EXPORT_SYMBOL not being defined and I see my own personal
> fix (which I had completely forgotten to send upstream) was to include
> <linux/exports.h>
core_marvel.c and core_titan.c both include <linux/module.h> in the
mainline kernel, which is why I thought it was the appropriate fix for
core_tsunami.c.
prev parent reply other threads:[~2012-02-18 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 0:35 Linux 3.2 fails to modpost on alpha arch: tsunami_ioportmap undefined Jim Faulkner
2012-02-18 21:24 ` [PATCH] fix modpost when CONFIG_ALPHA_TSUNAMI=y Jim Faulkner
2012-02-18 22:29 ` Michael Cree
2012-02-18 22:39 ` Jim Faulkner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120218223957.GB28758@alumni-linux.ccs.neu.edu \
--to=jfaulkne@ccs.neu.edu \
--cc=gregkh@linuxfoundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jay.estabrook@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mcree@orcon.net.nz \
--cc=rth@twiddle.net \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).