From: Fengguang Wu <fengguang.wu@intel.com>
To: Michael Cree <mcree@orcon.net.nz>
Cc: linux-alpha@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>, Tony Luck <tony.luck@gmail.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
John David Anglin <dave.anglin@bell.net>,
Mel Gorman <mgorman@suse.de>,
kernel-janitors@vger.kernel.org,
Kyle McMartin <kyle@parisc-linux.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Parisc List <linux-parisc@vger.kernel.org>
Subject: [PATCH] [ALPHA] Redefine ATOMIC_INIT and ATOMIC64_INIT to drop the casts
Date: Sun, 12 Aug 2012 10:14:05 +0800 [thread overview]
Message-ID: <20120812021405.GB8442@localhost> (raw)
In-Reply-To: <502707D5.7020602@orcon.net.nz>
From: Mel Gorman <mgorman@suse.de>
The following build error occurred during an alpha build:
net/core/sock.c:274:36: error: initializer element is not constant
Dave Anglin says:
> Here is the line in sock.i:
>
> struct static_key memalloc_socks = ((struct static_key) { .enabled =
> ((atomic_t) { (0) }) });
The above line contains two compound literals. It also uses a designated
initializer to initialize the field enabled. A compound literal is not a
constant expression.
The location of the above statement isn't fully clear, but if a compound
literal occurs outside the body of a function, the initializer list must
consist of constant expressions.
Cc: <stable@vger.kernel.org>
Signed-off-by: Mel Gorman <mgorman@suse.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
arch/alpha/include/asm/atomic.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux.orig/arch/alpha/include/asm/atomic.h 2012-08-12 10:12:36.667523339 +0800
+++ linux/arch/alpha/include/asm/atomic.h 2012-08-12 10:12:37.659523362 +0800
@@ -14,8 +14,8 @@
*/
-#define ATOMIC_INIT(i) ( (atomic_t) { (i) } )
-#define ATOMIC64_INIT(i) ( (atomic64_t) { (i) } )
+#define ATOMIC_INIT(i) { (i) }
+#define ATOMIC64_INIT(i) { (i) }
#define atomic_read(v) (*(volatile int *)&(v)->counter)
#define atomic64_read(v) (*(volatile long *)&(v)->counter)
next prev parent reply other threads:[~2012-08-12 2:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120722163058.GB13376@localhost>
[not found] ` <20120723111619.GT9222@suse.de>
[not found] ` <1343042420.3027.11.camel@dabdike.int.hansenpartnership.com>
[not found] ` <20120723114258.GV9222@suse.de>
[not found] ` <20120723122905.GA22476@localhost>
[not found] ` <BLU0-SMTP2254F8872DDE5FA6035CDE97DD0@phx.gbl>
[not found] ` <20120724074844.GA9519@localhost>
[not found] ` <BLU0-SMTP6C7CFCFF734FE10A39B6E97DC0@phx.gbl>
[not found] ` <1343193053.3139.6.camel@dabdike>
[not found] ` <CA+8MBbJkGN+zGBdD5Hg26wW_6E9L_ufoutn7wj+Y+nhtW7WKWg@mail.gmail.com>
2012-08-02 15:02 ` [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant Fengguang Wu
2012-08-12 1:33 ` Michael Cree
2012-08-12 2:10 ` Fengguang Wu
2012-08-12 2:42 ` Michael Cree
2012-08-12 13:00 ` John David Anglin
2012-08-12 2:14 ` Fengguang Wu [this message]
2012-08-15 22:03 ` [PATCH] [ALPHA] Redefine ATOMIC_INIT and ATOMIC64_INIT to drop the casts Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120812021405.GB8442@localhost \
--to=fengguang.wu@intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=dave.anglin@bell.net \
--cc=ink@jurassic.park.msu.ru \
--cc=kernel-janitors@vger.kernel.org \
--cc=kyle@parisc-linux.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mcree@orcon.net.nz \
--cc=mgorman@suse.de \
--cc=rth@twiddle.net \
--cc=tony.luck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).