From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [RFC 0/12] introduce down_write_killable for rw_semaphore Date: Thu, 10 Mar 2016 11:24:13 +0100 Message-ID: <20160310102412.GA21593@gmail.com> References: <1454444369-2146-1-git-send-email-mhocko@kernel.org> <20160309121850.GA14915@gmail.com> <20160309125641.GH27018@dhcp22.suse.cz> <20160309131710.GB7978@gmail.com> <20160309132855.GI27018@dhcp22.suse.cz> <20160309134339.GA20911@gmail.com> <20160309144140.GJ27018@dhcp22.suse.cz> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Pmwb66fbGa8Yt51YVAzk2ETImWwgo6t2fwzkR2FNgGI=; b=YcOaNNfFpSQonEvyjGKoCkYt4a8HD0aE/VTd5Q9tuYcO9879ZoOBKsHXqLCcbPaGmo H9Y7cR849flSihs+GjK/oSDDx0wTj5w5aA21jxNz/xB23FOgz9OiGNm7PfTDk96wBeXO NaKnGs2H0xMCL3xa3l3/WSKft6Sp3mfQ4TVD2RB6IUdXfpjFocFuS+NtKr+w5kfpf4q9 5IAO32l8TXG71rX1UcVUvm3IL5VuHWvnLuQLv9jfpTlanXJ5QamCFmzxwtiRWeyCZoTn TGQ/4xTlNzBM8NBlmEwuMKIuKg7v7Vx/XxQvRkoxuJ/6jeaXfrNO1Wt4SwMLiDiN//Yw Y46Q== Content-Disposition: inline In-Reply-To: <20160309144140.GJ27018@dhcp22.suse.cz> Sender: linux-ia64-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: LKML , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "David S. Miller" , Tony Luck , Andrew Morton , Chris Zankel , Max Filippov , x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org, Linus Torvalds , Peter Zijlstra * Michal Hocko wrote: > > > Why? Each syscall already is killable as the task might be killed by the OOM > > > killer. > > > > Not all syscalls are interruptible - for example sys_sync() isn't: > > I guess we are talking past each other. [...] Heh, you are being polite, I think what happened is that I was being dense and didn't understand your point: > [...] What I meant was that while all syscalls are allowed to not return to the > userspace because the task might get killed but not all of them accept to get > interrupted by a signal and return with EINTR. None of the man page of mmap, > mremap, mlock, mprotect list EINTR as a possibility so I would be really afraid > of returning an unexpected error code. Indeed. > Does this make more sense now? It does! Thanks, Ingo