Alpha arch development list
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Meelis Roos <mroos@linux.ee>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	linux-alpha@vger.kernel.org
Subject: Re: the patch "alpha/PCI: Replace pci_fixup_irqs()" breaks networking
Date: Thu, 4 Jan 2018 11:00:57 +0000	[thread overview]
Message-ID: <20180104110057.GC9230@red-moon> (raw)
In-Reply-To: <alpine.LRH.2.21.1801032149040.12580@math.ut.ee>

On Wed, Jan 03, 2018 at 09:50:42PM +0200, Meelis Roos wrote:
> > I suspect we ought to map IRQs early in this platform so that we are
> > able to detect how platform code should set them up.
> 
> SIO is used in multiple alpha platforms - should this patch work on all 
> of them?

This patch does nothing but assigning the IRQ earlier, as I said
in another thread I will modify it to make it simpler and avoid
relying on pci_assign_irq() - it was just to understand if my
assumption was right.

Lorenzo

> > Thanks,
> > Lorenzo
> > 
> > -- >8 --
> > diff --git a/arch/alpha/kernel/sys_sio.c b/arch/alpha/kernel/sys_sio.c
> > index 37bd6d9b8eb9..407ab603e9b1 100644
> > --- a/arch/alpha/kernel/sys_sio.c
> > +++ b/arch/alpha/kernel/sys_sio.c
> > @@ -114,6 +114,8 @@ sio_collect_irq_levels(void)
> >  		    (dev->class >> 8 != PCI_CLASS_BRIDGE_PCMCIA))
> >  			continue;
> >  
> > +		pci_assign_irq(dev);
> > +
> >  		if (dev->irq)
> >  			level_bits |= (1 << dev->irq);
> >  	}
> > 
> 
> -- 
> Meelis Roos (mroos@ut.ee)      http://www.cs.ut.ee/~mroos/

  reply	other threads:[~2018-01-04 11:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02 21:32 the patch "alpha/PCI: Replace pci_fixup_irqs()" breaks networking Mikulas Patocka
2018-01-02 21:50 ` Bjorn Helgaas
2018-01-02 21:54 ` Meelis Roos
2018-01-03 10:38   ` Lorenzo Pieralisi
2018-01-03 19:05     ` Mikulas Patocka
2018-01-04 10:46       ` Lorenzo Pieralisi
2018-01-03 19:05   ` Mikulas Patocka
2018-01-03 14:55 ` Lorenzo Pieralisi
2018-01-03 19:03   ` Mikulas Patocka
2018-01-04 10:58     ` Lorenzo Pieralisi
2018-01-03 19:50   ` Meelis Roos
2018-01-04 11:00     ` Lorenzo Pieralisi [this message]
2018-01-04 12:17 ` Lorenzo Pieralisi
2018-01-04 18:06   ` Mikulas Patocka
2018-01-04 18:49     ` Lorenzo Pieralisi
2018-01-05 11:23 ` Lorenzo Pieralisi
2018-01-05 18:49   ` Mikulas Patocka
2018-01-08 10:18     ` Lorenzo Pieralisi
2018-01-08 18:35       ` Mikulas Patocka
2018-01-09 12:16         ` Lorenzo Pieralisi
2018-01-09 19:13           ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180104110057.GC9230@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=bhelgaas@google.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mpatocka@redhat.com \
    --cc=mroos@linux.ee \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox