From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note" Date: Fri, 11 Oct 2019 09:11:43 -0700 Message-ID: <201910110910.48270FC97@keescook> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-2-keescook@chromium.org> <20191011082519.GI9749@gate.crashing.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=G6L52gHbcOVXjcPSYcPZfDCdfNGSvtith//1lglITt4=; b=U5/N6JMiUj9QDTd24aIgmkS/ZCmGBjpKwM7U8CzxrzMf1lqZSNfbZ7O4pwV0bhEzEg wudUUYrZzrgNiboJm0ChoceZ3O1LmYFYV3Bvx9uhV6vTeclkuNrnADNJMjD6VX65LBtL he7FMaEjTbOKTJQ5f79wUMqxbvVvSYa6+a7mg= Content-Disposition: inline In-Reply-To: <20191011082519.GI9749@gate.crashing.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Segher Boessenkool Cc: Borislav Petkov , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michal Simek , x86@kernel.org, linux-ia64@vger.kernel.org, Arnd Bergmann , linux-xtensa@linux-xtensa.org, Dave Hansen , Heiko Carstens , linuxppc-dev@lists.ozlabs.org, Yoshinori Sato , linux-parisc@vger.kernel.org, Andy Lutomirski , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, Rick Edgecombe , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org On Fri, Oct 11, 2019 at 03:25:19AM -0500, Segher Boessenkool wrote: > On Thu, Oct 10, 2019 at 05:05:41PM -0700, Kees Cook wrote: > > The Program Header identifiers are internal to the linker scripts. In > > preparation for moving the NOTES segment declaration into RO_DATA, > > standardize the identifier for the PT_NOTE entry to "note" as used by > > all other architectures that emit PT_NOTE. > > All other archs are wrong, and "notes" is a much better name. This > segment does not contain a single "note", but multiple "notes". True, but the naming appears to be based off the Program Header name of "PT_NOTE". Regardless, it is an entirely internal-to-the-linker-script identifier, so I am just consolidating on a common name with the least number of collateral changes. -- Kees Cook