From mboxrd@z Thu Jan 1 00:00:00 1970 From: Segher Boessenkool Subject: Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note" Date: Fri, 11 Oct 2019 11:25:52 -0500 Message-ID: <20191011162552.GK9749@gate.crashing.org> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-2-keescook@chromium.org> <20191011082519.GI9749@gate.crashing.org> <201910110910.48270FC97@keescook> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Mime-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r4RKYftH7rY3bK/9SWnLWc4c+k/JM1cewvK+WvL2bSo=; b=fWLusbc/iPKwxn guQ3AfYaluvQCdj9rT4UQWQ0ei4kXqza/l2/JSrMaN5EzCZjcydIaJY0qHWZC3HTpjGJIhaXfZ6oC QNiQ6aD56XrMHMi/b/RWnwmRKlKpaQ0RJWH7vToruy1M78ZUUp3RdwAKAY3icw5xrmPQ5ZEPwwRCu rV4PCvoTqaKH0KgoAs+orN4gjQ987YYTVI/zgQjkSWZWTnzx5xSCamd8uzn7sYcKgx1wXP+LDl5z6 85AtHHgXq1dgvSL57ZkHxe1yD39SyNpJCWyhC0+HVijrAkXBRlp8jq944qKaizCxU7UZltjLvaRMV HvweHBbYVkFHkhfUpUkA==; Content-Disposition: inline In-Reply-To: <201910110910.48270FC97@keescook> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kees Cook Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michal Simek , Dave Hansen , linux-ia64@vger.kernel.org, Yoshinori Sato , Arnd Bergmann , linux-xtensa@linux-xtensa.org, Will Deacon , x86@kernel.org, Heiko Carstens , linux-kernel@vger.kernel.org, Borislav Petkov , linux-parisc@vger.kernel.org, Andy Lutomirski , linux-alpha@vger.kernel.org, Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org On Fri, Oct 11, 2019 at 09:11:43AM -0700, Kees Cook wrote: > On Fri, Oct 11, 2019 at 03:25:19AM -0500, Segher Boessenkool wrote: > > On Thu, Oct 10, 2019 at 05:05:41PM -0700, Kees Cook wrote: > > > The Program Header identifiers are internal to the linker scripts. In > > > preparation for moving the NOTES segment declaration into RO_DATA, > > > standardize the identifier for the PT_NOTE entry to "note" as used by > > > all other architectures that emit PT_NOTE. > > > > All other archs are wrong, and "notes" is a much better name. This > > segment does not contain a single "note", but multiple "notes". > > True, but the naming appears to be based off the Program Header name of > "PT_NOTE". Ah, so that's why the kernel segment (which isn't text btw, it's rwx) is called "load" :-P (Not convinced. Some arch just got it wrong, and many others blindly copied it? That sounds a lot more likely imo.) > Regardless, it is an entirely internal-to-the-linker-script > identifier, so I am just consolidating on a common name with the least > number of collateral changes. Yes, that's what I'm complaining about. Names *matter*, internal names doubly so. So why replace a good name with a worse name? Because it is slightly less work for you? Segher p.s. Thanks for doing this, removing the powerpc workaround etc. :-)