From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v4 13/13] mm: remove __ARCH_HAS_4LEVEL_HACK and include/asm-generic/4level-fixup.h Date: Tue, 5 Nov 2019 17:13:09 -0800 Message-ID: <20191105171309.9a5ccf9cf14d7288f7adf198@linux-foundation.org> References: <1572938135-31886-1-git-send-email-rppt@kernel.org> <1572938135-31886-14-git-send-email-rppt@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573002791; bh=F8oZBAZiUgNBGiV+WdUohtNWYyfzETDe01QBSwwnbUE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LnltnbcoEvw0zudUzaix987ZKsj6MqDuFqsZC0+IjmxZ0XpTcoy82THWXKyrYQ0Ye mv5Z8zeYgtccYtyRipnP9TZaP3/JrnK54F4aJa9wN2ypZkOFNbFlBBd661zaIpobQL OZchQhXSAp1sAaj7ISlI/bn8Ev4MXWgPMnouR5wE= In-Reply-To: <1572938135-31886-14-git-send-email-rppt@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Mike Rapoport Cc: linux-mm@kvack.org, Anton Ivanov , Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Peter Rosin , Richard Weinberger , Rolf Eike Beer , Russell King , Sam Creasey , Vi On Tue, 5 Nov 2019 09:15:35 +0200 Mike Rapoport wrote: > There are no architectures that use include/asm-generic/4level-fixup.h > therefore it can be removed along with __ARCH_HAS_4LEVEL_HACK define. Conflicts a bit with Vineet's "asm-generic/tlb: stub out pud_free_tlb() if nopud ...", from http://lkml.kernel.org/r/20191016162400.14796-2-vgupta@synopsys.com I fixed it up by removing include/asm-generic/4level-fixup.h anyway and removing the removal of "#ifndef __ARCH_HAS_4LEVEL_HAC" from include/asm-generic/tlb.h.