* [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha
@ 2019-12-07 19:10 Arnd Bergmann
2019-12-07 22:54 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-12-07 19:10 UTC (permalink / raw)
To: Thomas Gleixner, Andrew Morton
Cc: linux-alpha, Richard Henderson, Ivan Kokshaysky, Matt Turner,
Arnd Bergmann, Guenter Roeck, kbuild test robot, linux-kernel
Using compat_sys_getitimer and compat_sys_setitimer on alpha
causes a link failure in the Alpha tinyconfig and other configurations
that turn off CONFIG_POSIX_TIMERS.
Use the same #ifdef check for the stub version as well.
Reported-by: Guenter Roeck <linux@roeck-us.net>
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 4c22ea2b9120 ("y2038: use compat_{get,set}_itimer on alpha")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/time/posix-stubs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/time/posix-stubs.c b/kernel/time/posix-stubs.c
index 67df65f887ac..20c65a7d4e3a 100644
--- a/kernel/time/posix-stubs.c
+++ b/kernel/time/posix-stubs.c
@@ -151,6 +151,9 @@ SYSCALL_DEFINE4(clock_nanosleep, const clockid_t, which_clock, int, flags,
#ifdef CONFIG_COMPAT
COMPAT_SYS_NI(timer_create);
+#endif
+
+#if defined(CONFIG_COMPAT) || defined(CONFIG_ALPHA)
COMPAT_SYS_NI(getitimer);
COMPAT_SYS_NI(setitimer);
#endif
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha
2019-12-07 19:10 [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha Arnd Bergmann
@ 2019-12-07 22:54 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2019-12-07 22:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Thomas Gleixner, Andrew Morton, linux-alpha, Richard Henderson,
Ivan Kokshaysky, Matt Turner, kbuild test robot, linux-kernel
On Sat, Dec 07, 2019 at 08:10:26PM +0100, Arnd Bergmann wrote:
> Using compat_sys_getitimer and compat_sys_setitimer on alpha
> causes a link failure in the Alpha tinyconfig and other configurations
> that turn off CONFIG_POSIX_TIMERS.
>
> Use the same #ifdef check for the stub version as well.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: 4c22ea2b9120 ("y2038: use compat_{get,set}_itimer on alpha")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> kernel/time/posix-stubs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/time/posix-stubs.c b/kernel/time/posix-stubs.c
> index 67df65f887ac..20c65a7d4e3a 100644
> --- a/kernel/time/posix-stubs.c
> +++ b/kernel/time/posix-stubs.c
> @@ -151,6 +151,9 @@ SYSCALL_DEFINE4(clock_nanosleep, const clockid_t, which_clock, int, flags,
>
> #ifdef CONFIG_COMPAT
> COMPAT_SYS_NI(timer_create);
> +#endif
> +
> +#if defined(CONFIG_COMPAT) || defined(CONFIG_ALPHA)
> COMPAT_SYS_NI(getitimer);
> COMPAT_SYS_NI(setitimer);
> #endif
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-07 22:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-07 19:10 [PATCH] time: posix-stubs: provide compat itimer supoprt for alpha Arnd Bergmann
2019-12-07 22:54 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).