From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH 03/12] mm: reorder includes after introduction of linux/pgtable.h Date: Wed, 13 May 2020 08:21:33 +0300 Message-ID: <20200513052133.GN14260@kernel.org> References: <20200512184422.12418-1-rppt@kernel.org> <20200512184422.12418-4-rppt@kernel.org> <20200512192013.GY16070@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wKjEKvhFUhgR7ia4lyQau2+4figsBfwpDpLc5pljkh0=; b=U/sKwG2tMYwE47 C6Y91rH/eAHR6ui86V4QbLr7tuZfHtz9i93MhbvN3xfluWvCcmSokkcyf3VubXWuuHnZXLaaJtI75 6xeIxc/SEyAL8aqaFU4iWErz7+c4ZvLV7y57gZIzWvHdasRK/H+Ts7vrpiSt00YwUzrH6cYBrPWV9 jObABsjQ6yi2aYDKQY6Q+81a5bahCPak3LHQCoEljMpFlwp0fW6RhopFkLJzqe1MQlXx2DQ33bLhf Dg/WQzJnQZ9hBZ47tL8FmgU+b3dt5jyp4oIfv+HyvWzq0Xus//AJGRoIPdo9MaicD+GAw0Nm6jQyO KPOTkxn2KDZOF9V0XRKQ==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589347309; bh=eXxsFWMRwsjxCxIEwZvSMlzVp4JoExGumCwVZGQ437k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C67nj68nb/WBhkQSlanqvNkuKuI8DtxJ9ZixH0J1b2BuEaAk5a5wNzO7jtcEk7q0p JlpDcwhtcaCA3Vi5e8fc7aXovPbaDZ6qYnKJdRNeliw/je8Bz0w2ebGvIUy/BChi12 FHMPcFva8/LxUc1i7w8oclm0hcf1j8ysLYGt5c9s= Content-Disposition: inline In-Reply-To: <20200512192013.GY16070@bombadil.infradead.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane-mx.org@lists.infradead.org To: Matthew Wilcox Cc: Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Heiko Carstens , linux-mips@vger.kernel.org, Max Filippov , Guo Ren , linux-csky@vger.kernel.org, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Vincent Chen , Will Deacon , Greg Ungerer , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Brian Cain , Michael Ellerman , Helge Deller , x86@kernel.org, Russell King , Ley Foon Tan , Mike Rapoport , Ingo Molnar , Geert Uytterhoeven , lin On Tue, May 12, 2020 at 12:20:13PM -0700, Matthew Wilcox wrote: > On Tue, May 12, 2020 at 09:44:13PM +0300, Mike Rapoport wrote: > > diff --git a/arch/alpha/kernel/proto.h b/arch/alpha/kernel/proto.h > > index a093cd45ec79..701a05090141 100644 > > --- a/arch/alpha/kernel/proto.h > > +++ b/arch/alpha/kernel/proto.h > > @@ -2,8 +2,6 @@ > > #include > > #include > > > > -#include > > - > > /* Prototypes of functions used across modules here in this directory. */ > > > > #define vucp volatile unsigned char * > > Looks like your script has a bug if linux/pgtable.h is the last include > in the file? Script indeed cannot handle all the corner case, but this is not one of them. I've started initially to look into removing asm/pgtable.h if it was not needed, but I've run out of patience very soon. This file is what sneaked in from that attempt. -- Sincerely yours, Mike.