From: Bjorn Helgaas <helgaas@kernel.org>
To: "Saheed O. Bolarinwa" <refactormyself@gmail.com>
Cc: Rich Felker <dalias@libc.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-sh@vger.kernel.org, linux-pci@vger.kernel.org,
linux-nvme@lists.infradead.org,
Yicong Yang <yangyicong@hisilicon.com>,
Keith Busch <kbusch@kernel.org>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
Paul Mackerras <paulus@samba.org>,
linux-i2c@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
sparclinux@vger.kernel.org, rfi@lists.rocketboards.org,
Toan Le <toan@os.amperecomputing.com>,
Greg Ungerer <gerg@linux-m68k.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Rob Herring <robh@kernel.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-scsi@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-atm-general@lists.sourceforge.net
Subject: Re: [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86
Date: Mon, 13 Jul 2020 17:01:56 -0500 [thread overview]
Message-ID: <20200713220156.GA284762@bjorn-Precision-5520> (raw)
In-Reply-To: <20200713122247.10985-1-refactormyself@gmail.com>
On Mon, Jul 13, 2020 at 02:22:12PM +0200, Saheed O. Bolarinwa wrote:
> This goal of these series is to move the definition of *all* PCIBIOS* from
> include/linux/pci.h to arch/x86 and limit their use within there.
> All other tree specific definition will be left for intact. Maybe they can
> be renamed.
More comments later, but a few trivial whitespace issues you can clean
up in the meantime. Don't repost for at least a few days to avoid
spamming everybody. I found these with:
$ b4 am -om/ 20200713122247.10985-1-refactormyself@gmail.com
$ git am m/20200713_refactormyself_move_all_pcibios_definitions_into_arch_x86.mbx
Applying: atm: Change PCIBIOS_SUCCESSFUL to 0
.git/rebase-apply/patch:11: trailing whitespace.
iadev = INPH_IA_DEV(dev);
.git/rebase-apply/patch:12: trailing whitespace.
for(i=0; i<64; i++)
.git/rebase-apply/patch:13: trailing whitespace.
if ((error = pci_read_config_dword(iadev->pci,
.git/rebase-apply/patch:16: trailing whitespace, space before tab in indent.
return error;
.git/rebase-apply/patch:17: trailing whitespace.
writel(0, iadev->reg+IPHASE5575_EXT_RESET);
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.
Applying: atm: Tidy Success/Failure checks
.git/rebase-apply/patch:13: trailing whitespace.
.git/rebase-apply/patch:14: trailing whitespace.
iadev = INPH_IA_DEV(dev);
.git/rebase-apply/patch:15: trailing whitespace.
for(i=0; i<64; i++)
.git/rebase-apply/patch:21: trailing whitespace.
writel(0, iadev->reg+IPHASE5575_EXT_RESET);
.git/rebase-apply/patch:22: trailing whitespace.
for(i=0; i<64; i++)
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.
Applying: atm: Fix Style ERROR- assignment in if condition
.git/rebase-apply/patch:12: trailing whitespace.
unsigned int pci[64];
.git/rebase-apply/patch:13: trailing whitespace.
.git/rebase-apply/patch:14: trailing whitespace.
iadev = INPH_IA_DEV(dev);
.git/rebase-apply/patch:23: trailing whitespace.
writel(0, iadev->reg+IPHASE5575_EXT_RESET);
.git/rebase-apply/patch:32: trailing whitespace.
udelay(5);
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.
Applying: PCI: Change PCIBIOS_SUCCESSFUL to 0
.git/rebase-apply/patch:37: trailing whitespace.
struct pci_ops apecs_pci_ops =
.git/rebase-apply/patch:50: trailing whitespace.
static int
.git/rebase-apply/patch:59: trailing whitespace.
struct pci_ops cia_pci_ops =
.git/rebase-apply/patch:94: trailing whitespace.
static int
.git/rebase-apply/patch:103: trailing whitespace.
struct pci_ops lca_pci_ops =
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
prev parent reply other threads:[~2020-07-13 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 12:22 [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86 Saheed O. Bolarinwa
2020-07-13 12:22 ` [RFC PATCH 34/35] PCI: Change PCIBIOS_SUCCESSFUL to 0 Saheed O. Bolarinwa
2020-07-13 12:22 ` [RFC PATCH 35/35] alpha: Tidy Success/Failure checks Saheed O. Bolarinwa
2020-07-13 15:08 ` [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86 Arnd Bergmann
2020-07-13 22:01 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713220156.GA284762@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dalias@libc.org \
--cc=gerg@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbusch@kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=nic_swsd@realtek.com \
--cc=paulus@samba.org \
--cc=refactormyself@gmail.com \
--cc=rfi@lists.rocketboards.org \
--cc=robh@kernel.org \
--cc=sagi@grimberg.me \
--cc=sparclinux@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=toan@os.amperecomputing.com \
--cc=yangyicong@hisilicon.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).