From: Greg KH <gregkh@linuxfoundation.org>
To: Anshul <anshulusr@gmail.com>
Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru,
mattst88@gmail.com, linux-alpha@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixed formatting issues
Date: Mon, 28 Aug 2023 11:11:28 +0200 [thread overview]
Message-ID: <2023082801-cost-radiance-95fa@gregkh> (raw)
In-Reply-To: <CAPwwkU7+zHo2jpt+ovJDE1ca=K8AKyowyA5Z9pOFAy6iifVEwA@mail.gmail.com>
On Mon, Aug 28, 2023 at 01:54:41PM +0530, Anshul wrote:
> Hello Greg,
>
> > - Your patch did many different things all at once, making it difficult
> > to review. All Linux kernel patches need to only do one thing at a
> > time. If you need to do multiple things (such as clean up all coding
> > style issues in a file/driver), do it in a sequence of patches, each
> > one doing only one thing. This will make it easier to review the
> > patches to ensure that they are correct, and to help alleviate any
> > merge issues that larger patches can cause.
>
> I believe that splitting the patch is not necessary in this instance since
> the changes are localized and trivial to reason about.
That's up to the maintainer to decide.
> > - You did not write a descriptive Subject: for the patch, allowing
> > everyone, to know what this patch is all about. Please read the
> > section entitled "The canonical patch format" in the kernel file,
> > Documentation/process/submitting-patches.rst for what a proper
> > Subject: line should look like.
>
> As per the feedback, the updated patch has incorporated the changes.
Why are you changing coding style issues in this portion of the kernel?
Do you have this hardware to test with?
Normally coding style cleanups like this are only allowed in the
drivers/staging/* portion of the kernel. Unless you get approval from
the maintainer of the subsystem you are changing, I wouldn't work on
this as it's generally considered bad form.
> > - It looks like you did not use your "real" name for the patch on either
> > the Signed-off-by: line, or the From: line (both of which have to
> > match). Please read the kernel file,
> > Documentation/process/submitting-patches.rst for how to do this
> > correctly.
>
> I have verified that the Signed-off-by: line and the From: line contain the
> same content.
Your name is only 1 word?
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-28 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 7:18 [PATCH] fixed formatting issues Anshul
2023-08-28 7:28 ` Greg KH
2023-08-28 8:24 ` Anshul
2023-08-28 9:11 ` Greg KH [this message]
2023-08-28 10:22 ` Anshul
2023-08-28 8:06 ` [PATCH] alpha/boot: fixes formatting issues in `main.c` Anshul
2023-08-28 9:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023082801-cost-radiance-95fa@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=anshulusr@gmail.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).