public inbox for linux-alpha@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] alpha: trivial: remove ^L chars
@ 2025-12-28  6:34 Askar Safin
  2025-12-28  6:34 ` [PATCH 1/1] " Askar Safin
  0 siblings, 1 reply; 8+ messages in thread
From: Askar Safin @ 2025-12-28  6:34 UTC (permalink / raw)
  To: Richard Henderson, Matt Turner, Magnus Lindholm, linux-alpha
  Cc: kernel-janitors, linux-kernel, patches

Remove ^L (a. k. a. \f a. k. a. form feed a. k. a. \x0c) from arch/alpha.
I'm attempting to write my own tool for parsing kernel code.
And these characters complicate this without giving any benefits.

Askar Safin (1):
  alpha: trivial: remove ^L chars

 arch/alpha/kernel/core_cia.c      |  6 ++---
 arch/alpha/kernel/core_irongate.c |  2 +-
 arch/alpha/kernel/core_marvel.c   | 18 +++++++--------
 arch/alpha/kernel/core_mcpcia.c   |  4 ++--
 arch/alpha/kernel/core_polaris.c  |  2 +-
 arch/alpha/kernel/core_t2.c       |  2 +-
 arch/alpha/kernel/core_titan.c    | 10 ++++----
 arch/alpha/kernel/core_tsunami.c  |  4 ++--
 arch/alpha/kernel/err_common.c    |  4 ++--
 arch/alpha/kernel/err_titan.c     |  2 +-
 arch/alpha/kernel/pci_iommu.c     |  4 ++--
 arch/alpha/kernel/smc37c669.c     | 38 +++++++++++++++----------------
 arch/alpha/kernel/sys_marvel.c    |  4 ++--
 arch/alpha/kernel/sys_titan.c     |  8 +++----
 arch/alpha/kernel/time.c          | 10 ++++----
 15 files changed, 59 insertions(+), 59 deletions(-)


base-commit: 9448598b22c50c8a5bb77a9103e2d49f134c9578 (6.19-rc2)
-- 
2.47.3


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/1] alpha: trivial: remove ^L chars
  2025-12-28  6:34 [PATCH 0/1] alpha: trivial: remove ^L chars Askar Safin
@ 2025-12-28  6:34 ` Askar Safin
  2026-01-05 10:38   ` Magnus Lindholm
  0 siblings, 1 reply; 8+ messages in thread
From: Askar Safin @ 2025-12-28  6:34 UTC (permalink / raw)
  To: Richard Henderson, Matt Turner, Magnus Lindholm, linux-alpha
  Cc: kernel-janitors, linux-kernel, patches

Remove ^L (a. k. a. \f a. k. a. form feed a. k. a. \x0c) from arch/alpha.
I'm attempting to write my own tool for parsing kernel code.
And these characters complicate this without giving any benefits.

Signed-off-by: Askar Safin <safinaskar@gmail.com>
---
 arch/alpha/kernel/core_cia.c      |  6 ++---
 arch/alpha/kernel/core_irongate.c |  2 +-
 arch/alpha/kernel/core_marvel.c   | 18 +++++++--------
 arch/alpha/kernel/core_mcpcia.c   |  4 ++--
 arch/alpha/kernel/core_polaris.c  |  2 +-
 arch/alpha/kernel/core_t2.c       |  2 +-
 arch/alpha/kernel/core_titan.c    | 10 ++++----
 arch/alpha/kernel/core_tsunami.c  |  4 ++--
 arch/alpha/kernel/err_common.c    |  4 ++--
 arch/alpha/kernel/err_titan.c     |  2 +-
 arch/alpha/kernel/pci_iommu.c     |  4 ++--
 arch/alpha/kernel/smc37c669.c     | 38 +++++++++++++++----------------
 arch/alpha/kernel/sys_marvel.c    |  4 ++--
 arch/alpha/kernel/sys_titan.c     |  8 +++----
 arch/alpha/kernel/time.c          | 10 ++++----
 15 files changed, 59 insertions(+), 59 deletions(-)

diff --git a/arch/alpha/kernel/core_cia.c b/arch/alpha/kernel/core_cia.c
index 6e577228e175..af571073266c 100644
--- a/arch/alpha/kernel/core_cia.c
+++ b/arch/alpha/kernel/core_cia.c
@@ -246,7 +246,7 @@ struct pci_ops cia_pci_ops =
 	.read = 	cia_read_config,
 	.write =	cia_write_config,
 };
-\f
+
 /*
  * CIA Pass 1 and PYXIS Pass 1 and 2 have a broken scatter-gather tlb.
  * It cannot be invalidated.  Rather than hard code the pass numbers,
@@ -555,7 +555,7 @@ verify_tb_operation(void)
 	alpha_mv.mv_pci_tbi = NULL;
 	goto exit;
 }
-\f
+
 #if defined(ALPHA_RESTORE_SRM_SETUP)
 /* Save CIA configuration data as the console had it set up.  */
 struct 
@@ -626,7 +626,7 @@ cia_restore_srm_settings(void)
 #define cia_restore_srm_settings()	do {} while (0)
 #endif /* ALPHA_RESTORE_SRM_SETUP */
 
-\f
+
 static void __init
 do_init_arch(int is_pyxis)
 {
diff --git a/arch/alpha/kernel/core_irongate.c b/arch/alpha/kernel/core_irongate.c
index 05dc4c1b9074..a47b4c48a7d3 100644
--- a/arch/alpha/kernel/core_irongate.c
+++ b/arch/alpha/kernel/core_irongate.c
@@ -160,7 +160,7 @@ struct pci_ops irongate_pci_ops =
 	.read =		irongate_read_config,
 	.write =	irongate_write_config,
 };
-\f
+
 int
 irongate_pci_clr_err(void)
 {
diff --git a/arch/alpha/kernel/core_marvel.c b/arch/alpha/kernel/core_marvel.c
index d38f4d6759e4..5ac99c6b0d17 100644
--- a/arch/alpha/kernel/core_marvel.c
+++ b/arch/alpha/kernel/core_marvel.c
@@ -30,7 +30,7 @@
 #include "proto.h"
 #include "pci_impl.h"
 
-\f
+
 /*
  * Debug helpers
  */
@@ -42,13 +42,13 @@
 # define DBG_CFG(args)
 #endif
 
-\f
+
 /*
  * Private data
  */
 static struct io7 *io7_head = NULL;
 
-\f
+
 /*
  * Helper functions
  */
@@ -194,7 +194,7 @@ io7_clear_errors(struct io7 *io7)
 	p7csrs->PO7_CRRCT_SYM.csr = -1UL;
 }
 
-\f
+
 /*
  * IO7 PCI, PCI/X, AGP configuration.
  */
@@ -468,7 +468,7 @@ marvel_kill_arch(int mode)
 {
 }
 
-\f
+
 /*
  * PCI Configuration Space access functions
  *
@@ -596,7 +596,7 @@ struct pci_ops marvel_pci_ops =
 	.write = 	marvel_write_config,
 };
 
-\f
+
 /*
  * Other PCI helper functions.
  */
@@ -611,8 +611,8 @@ marvel_pci_tbi(struct pci_controller *hose, dma_addr_t start, dma_addr_t end)
 	csrs->POx_SG_TBIA.csr;
 }
 
-\f
-\f
+
+
 /*
  * RTC Support
  */
@@ -673,7 +673,7 @@ __marvel_rtc_io(u8 b, unsigned long addr, int write)
 	return ret;
 }
 
-\f
+
 /*
  * IO map support.
  */
diff --git a/arch/alpha/kernel/core_mcpcia.c b/arch/alpha/kernel/core_mcpcia.c
index 74b1d018124c..e7f5ecb31991 100644
--- a/arch/alpha/kernel/core_mcpcia.c
+++ b/arch/alpha/kernel/core_mcpcia.c
@@ -241,7 +241,7 @@ struct pci_ops mcpcia_pci_ops =
 	.read =		mcpcia_read_config,
 	.write =	mcpcia_write_config,
 };
-\f
+
 void
 mcpcia_pci_tbi(struct pci_controller *hose, dma_addr_t start, dma_addr_t end)
 {
@@ -249,7 +249,7 @@ mcpcia_pci_tbi(struct pci_controller *hose, dma_addr_t start, dma_addr_t end)
 	*(vuip)MCPCIA_SG_TBIA(MCPCIA_HOSE2MID(hose->index)) = 0;
 	mb();
 }
-\f
+
 static int __init
 mcpcia_probe_hose(int h)
 {
diff --git a/arch/alpha/kernel/core_polaris.c b/arch/alpha/kernel/core_polaris.c
index 75d622d96ff2..797b1bda0ec8 100644
--- a/arch/alpha/kernel/core_polaris.c
+++ b/arch/alpha/kernel/core_polaris.c
@@ -142,7 +142,7 @@ struct pci_ops polaris_pci_ops =
 	.read =		polaris_read_config,
 	.write =	polaris_write_config,
 };
-\f
+
 void __init
 polaris_init_arch(void)
 {
diff --git a/arch/alpha/kernel/core_t2.c b/arch/alpha/kernel/core_t2.c
index 3d72d90624f1..82887e882667 100644
--- a/arch/alpha/kernel/core_t2.c
+++ b/arch/alpha/kernel/core_t2.c
@@ -321,7 +321,7 @@ struct pci_ops t2_pci_ops =
 	.read =		t2_read_config,
 	.write =	t2_write_config,
 };
-\f
+
 static void __init
 t2_direct_map_window1(unsigned long base, unsigned long length)
 {
diff --git a/arch/alpha/kernel/core_titan.c b/arch/alpha/kernel/core_titan.c
index 77f5d68ed04b..3a217dc3bb3c 100644
--- a/arch/alpha/kernel/core_titan.c
+++ b/arch/alpha/kernel/core_titan.c
@@ -52,7 +52,7 @@ static int titan_pchip1_present;
 # define DBG_CFG(args)
 #endif
 
-\f
+
 /*
  * Routines to access TIG registers.
  */
@@ -76,7 +76,7 @@ titan_write_tig(int offset, u8 value)
 	*tig_addr = (unsigned long)value;
 }
 
-\f
+
 /*
  * Given a bus, device, and function number, compute resulting
  * configuration space address
@@ -197,7 +197,7 @@ struct pci_ops titan_pci_ops =
 	.write =	titan_write_config,
 };
 
-\f
+
 void
 titan_pci_tbi(struct pci_controller *hose, dma_addr_t start, dma_addr_t end)
 {
@@ -438,7 +438,7 @@ titan_kill_arch(int mode)
 	titan_kill_pachips(TITAN_pachip0, TITAN_pachip1);
 }
 
-\f
+
 /*
  * IO map support.
  */
@@ -571,7 +571,7 @@ EXPORT_SYMBOL(titan_ioremap);
 EXPORT_SYMBOL(titan_iounmap);
 EXPORT_SYMBOL(titan_is_mmio);
 #endif
-\f
+
 /*
  * AGP GART Support.
  */
diff --git a/arch/alpha/kernel/core_tsunami.c b/arch/alpha/kernel/core_tsunami.c
index fc1ab73f23de..e3452b38e12a 100644
--- a/arch/alpha/kernel/core_tsunami.c
+++ b/arch/alpha/kernel/core_tsunami.c
@@ -173,7 +173,7 @@ struct pci_ops tsunami_pci_ops =
 	.read =		tsunami_read_config,
 	.write = 	tsunami_write_config,
 };
-\f
+
 void
 tsunami_pci_tbi(struct pci_controller *hose, dma_addr_t start, dma_addr_t end)
 {
@@ -195,7 +195,7 @@ tsunami_pci_tbi(struct pci_controller *hose, dma_addr_t start, dma_addr_t end)
 	mb();
 	*csr;
 }
-\f
+
 #ifdef NXM_MACHINE_CHECKS_ON_TSUNAMI
 static long __init
 tsunami_probe_read(volatile unsigned long *vaddr)
diff --git a/arch/alpha/kernel/err_common.c b/arch/alpha/kernel/err_common.c
index 94e1b3dcf6d4..877b5231953d 100644
--- a/arch/alpha/kernel/err_common.c
+++ b/arch/alpha/kernel/err_common.c
@@ -24,7 +24,7 @@
  */
 char *err_print_prefix = KERN_NOTICE;
 
-\f
+
 /*
  * Generic
  */
@@ -77,7 +77,7 @@ mchk_dump_logout_frame(struct el_common *mchk_header)
 	printk("%s  -- End of Frame --\n", err_print_prefix);
 }
 
-\f
+
 /*
  * Console Data Log
  */
diff --git a/arch/alpha/kernel/err_titan.c b/arch/alpha/kernel/err_titan.c
index 0ffb2feea42a..d5c4c690209e 100644
--- a/arch/alpha/kernel/err_titan.c
+++ b/arch/alpha/kernel/err_titan.c
@@ -581,7 +581,7 @@ titan_register_error_handlers(void)
 	ev6_register_error_handlers();
 }
 
-\f
+
 /*
  * Privateer
  */
diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c
index 955b6ca61627..9d49908ee2dc 100644
--- a/arch/alpha/kernel/pci_iommu.c
+++ b/arch/alpha/kernel/pci_iommu.c
@@ -55,7 +55,7 @@ size_for_memory(unsigned long max)
 		max = roundup_pow_of_two(mem);
 	return max;
 }
-\f
+
 struct pci_iommu_arena * __init
 iommu_arena_new_node(int nid, struct pci_controller *hose, dma_addr_t base,
 		     unsigned long window_size, unsigned long align)
@@ -810,7 +810,7 @@ static int alpha_pci_supported(struct device *dev, u64 mask)
 	return 0;
 }
 
-\f
+
 /*
  * AGP GART extensions to the IOMMU
  */
diff --git a/arch/alpha/kernel/smc37c669.c b/arch/alpha/kernel/smc37c669.c
index a5a6ed97a6ce..8f7a4520771f 100644
--- a/arch/alpha/kernel/smc37c669.c
+++ b/arch/alpha/kernel/smc37c669.c
@@ -1093,7 +1093,7 @@ static int SMC37c669_xlate_drq(
 );
 
 static  __cacheline_aligned DEFINE_SPINLOCK(smc_lock);
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -1189,7 +1189,7 @@ SMC37c669_CONFIG_REGS * __init SMC37c669_detect( int index )
     return SMC37c669;
 }
 
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -1421,7 +1421,7 @@ unsigned int __init SMC37c669_enable_device ( unsigned int func )
     return ret_val;
 }
 
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -1625,7 +1625,7 @@ unsigned int __init SMC37c669_disable_device ( unsigned int func )
     return ret_val;
 }
 
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -1702,7 +1702,7 @@ unsigned int __init SMC37c669_configure_device (
     return FALSE;
 }
 
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -1789,7 +1789,7 @@ static unsigned int __init SMC37c669_is_device_enabled ( unsigned int func )
     return ret_val;
 }
 
-\f
+
 #if 0
 /*
 **++
@@ -1861,7 +1861,7 @@ static unsigned int __init SMC37c669_get_device_config (
 }
 #endif
 
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -1938,7 +1938,7 @@ void __init SMC37c669_display_device_info ( void )
     }
 }
 
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -1981,7 +1981,7 @@ static void __init SMC37c669_config_mode(
     	wb( &SMC37c669->index_port, SMC37c669_CONFIG_OFF_KEY );
     }
 }
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -2011,7 +2011,7 @@ static unsigned char __init SMC37c669_read_config(
 	wb(&SMC37c669->index_port, index);
 	return rb(&SMC37c669->data_port);
 }
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -2046,7 +2046,7 @@ static void __init SMC37c669_write_config(
     wb( &SMC37c669->data_port, data );
 }
 
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -2175,7 +2175,7 @@ static void __init SMC37c669_init_local_config ( void )
     local_config[IDE_0].irq = 14;
 }
 
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -2222,7 +2222,7 @@ static struct DEVICE_CONFIG * __init SMC37c669_get_config( unsigned int func )
     }
     return cp;
 }
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -2274,7 +2274,7 @@ static int __init SMC37c669_xlate_irq ( int irq )
     return translated_irq;
 }
 
-\f
+
 /*
 **++
 **  FUNCTIONAL DESCRIPTION:
@@ -2325,7 +2325,7 @@ static int __init SMC37c669_xlate_drq ( int drq )
     }
     return translated_drq;
 }
-\f
+
 #if 0
 int __init smcc669_init ( void )
 {
@@ -2340,7 +2340,7 @@ int __init smcc669_init ( void )
 
     return msg_success;
 }
-\f
+
 int __init smcc669_open( struct FILE *fp, char *info, char *next, char *mode )
 {
     struct INODE *ip;
@@ -2365,7 +2365,7 @@ int __init smcc669_open( struct FILE *fp, char *info, char *next, char *mode )
 
     return msg_success;
 }
-\f
+
 int __init smcc669_close( struct FILE *fp )
 {
     struct INODE *ip;
@@ -2378,7 +2378,7 @@ int __init smcc669_close( struct FILE *fp )
     }
     return msg_success;
 }
-\f
+
 int __init smcc669_read( struct FILE *fp, int size, int number, unsigned char *buf )
 {
     int i;
@@ -2404,7 +2404,7 @@ int __init smcc669_read( struct FILE *fp, int size, int number, unsigned char *b
     SMC37c669_config_mode( FALSE );
     return nbytes;
 }
-\f
+
 int __init smcc669_write( struct FILE *fp, int size, int number, unsigned char *buf )
 {
     int i;
diff --git a/arch/alpha/kernel/sys_marvel.c b/arch/alpha/kernel/sys_marvel.c
index 1f99b03effc2..4c38ad39fd37 100644
--- a/arch/alpha/kernel/sys_marvel.c
+++ b/arch/alpha/kernel/sys_marvel.c
@@ -33,7 +33,7 @@
 # error NR_IRQS < MARVEL_NR_IRQS !!!
 #endif
 
-\f
+
 /*
  * Interrupt handling.
  */
@@ -432,7 +432,7 @@ marvel_smp_callin(void)
 	for (i = 0; i < 16; ++i)
 		io7_redirect_one_msi(io7, i, cpuid);
 }
-\f
+
 /*
  * System Vectors
  */
diff --git a/arch/alpha/kernel/sys_titan.c b/arch/alpha/kernel/sys_titan.c
index b1f3b4fcf99b..1af0d909f436 100644
--- a/arch/alpha/kernel/sys_titan.c
+++ b/arch/alpha/kernel/sys_titan.c
@@ -36,7 +36,7 @@
 #include "machvec_impl.h"
 #include "err_impl.h"
 
-\f
+
 /*
  * Titan generic
  */
@@ -255,7 +255,7 @@ titan_dispatch_irqs(u64 mask)
 	}
 }
   
-\f
+
 /*
  * Titan Family
  */
@@ -337,7 +337,7 @@ titan_init_pci(void)
 	locate_and_init_vga(NULL);
 }
 
-\f
+
 /*
  * Privateer
  */
@@ -359,7 +359,7 @@ privateer_init_pci(void)
 	return titan_init_pci();
 }
 
-\f
+
 /*
  * The System Vectors.
  */
diff --git a/arch/alpha/kernel/time.c b/arch/alpha/kernel/time.c
index 4d01c392ab14..1ed69632b01e 100644
--- a/arch/alpha/kernel/time.c
+++ b/arch/alpha/kernel/time.c
@@ -80,7 +80,7 @@ static inline __u32 rpcc(void)
 }
 
 
-\f
+
 /*
  * The RTC as a clock_event_device primitive.
  */
@@ -129,7 +129,7 @@ init_rtc_clockevent(void)
 	clockevents_config_and_register(ce, CONFIG_HZ, 0, 0);
 }
 
-\f
+
 /*
  * The QEMU clock as a clocksource primitive.
  */
@@ -199,7 +199,7 @@ init_qemu_clockevent(void)
 	clockevents_config_and_register(ce, NSEC_PER_SEC, 1000, LONG_MAX);
 }
 
-\f
+
 void __init
 common_init_rtc(void)
 {
@@ -245,7 +245,7 @@ common_init_rtc(void)
 	init_rtc_irq(NULL);
 }
 
-\f
+
 #ifndef CONFIG_ALPHA_WTINT
 /*
  * The RPCC as a clocksource primitive.
@@ -275,7 +275,7 @@ static struct clocksource clocksource_rpcc = {
 };
 #endif /* ALPHA_WTINT */
 
-\f
+
 /* Validate a computed cycle counter result against the known bounds for
    the given processor core.  There's too much brokenness in the way of
    timing hardware for any one method to work everywhere.  :-(
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/1] alpha: trivial: remove ^L chars
  2025-12-28  6:34 ` [PATCH 1/1] " Askar Safin
@ 2026-01-05 10:38   ` Magnus Lindholm
  2026-01-06 13:17     ` Maciej W. Rozycki
  0 siblings, 1 reply; 8+ messages in thread
From: Magnus Lindholm @ 2026-01-05 10:38 UTC (permalink / raw)
  To: Askar Safin
  Cc: Richard Henderson, Matt Turner, linux-alpha, kernel-janitors,
	linux-kernel, patches

On Sun, Dec 28, 2025 at 7:35 AM Askar Safin <safinaskar@gmail.com> wrote:
>
> Remove ^L (a. k. a. \f a. k. a. form feed a. k. a. \x0c) from arch/alpha.
> I'm attempting to write my own tool for parsing kernel code.
> And these characters complicate this without giving any benefits.
>
> Signed-off-by: Askar Safin <safinaskar@gmail.com>
> ---
>  arch/alpha/kernel/core_cia.c      |  6 ++---
>  arch/alpha/kernel/core_irongate.c |  2 +-
>  arch/alpha/kernel/core_marvel.c   | 18 +++++++--------
>  arch/alpha/kernel/core_mcpcia.c   |  4 ++--
>  arch/alpha/kernel/core_polaris.c  |  2 +-
>  arch/alpha/kernel/core_t2.c       |  2 +-
>  arch/alpha/kernel/core_titan.c    | 10 ++++----
>  arch/alpha/kernel/core_tsunami.c  |  4 ++--
>  arch/alpha/kernel/err_common.c    |  4 ++--
>  arch/alpha/kernel/err_titan.c     |  2 +-
>  arch/alpha/kernel/pci_iommu.c     |  4 ++--
>  arch/alpha/kernel/smc37c669.c     | 38 +++++++++++++++----------------
>  arch/alpha/kernel/sys_marvel.c    |  4 ++--
>  arch/alpha/kernel/sys_titan.c     |  8 +++----
>  arch/alpha/kernel/time.c          | 10 ++++----
>  15 files changed, 59 insertions(+), 59 deletions(-)
>

Nice cleanup work.

For a v2, please consider adjusting the commit message rationale away from
personal tooling and towards general readability and editor/tool compatibility.
Otherwise this looks fine to me.

Magnus

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/1] alpha: trivial: remove ^L chars
  2026-01-05 10:38   ` Magnus Lindholm
@ 2026-01-06 13:17     ` Maciej W. Rozycki
  2026-01-06 16:30       ` Magnus Lindholm
  2026-01-11 11:35       ` Askar Safin
  0 siblings, 2 replies; 8+ messages in thread
From: Maciej W. Rozycki @ 2026-01-06 13:17 UTC (permalink / raw)
  To: Magnus Lindholm
  Cc: Askar Safin, Richard Henderson, Matt Turner, linux-alpha,
	kernel-janitors, linux-kernel, patches

On Mon, 5 Jan 2026, Magnus Lindholm wrote:

> For a v2, please consider adjusting the commit message rationale away from
> personal tooling and towards general readability and editor/tool compatibility.

 As a matter of interest, why would the presence of ^L characters cause 
any issues?  That is just another instance of white space and it has been 
commonly used across some source code to separate functional parts, e.g. 
in the GNU toolchain.  It can be ignored unless you actually send the code 
to a printer (which I suppose hardly anyone does nowadays).

  Maciej

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/1] alpha: trivial: remove ^L chars
  2026-01-06 13:17     ` Maciej W. Rozycki
@ 2026-01-06 16:30       ` Magnus Lindholm
  2026-01-06 17:17         ` Maciej W. Rozycki
  2026-01-11 11:35       ` Askar Safin
  1 sibling, 1 reply; 8+ messages in thread
From: Magnus Lindholm @ 2026-01-06 16:30 UTC (permalink / raw)
  To: Maciej W. Rozycki
  Cc: Askar Safin, Richard Henderson, Matt Turner, linux-alpha,
	kernel-janitors, linux-kernel, patches

>  As a matter of interest, why would the presence of ^L characters cause
> any issues?  That is just another instance of white space and it has been
> commonly used across some source code to separate functional parts, e.g.
> in the GNU toolchain.  It can be ignored unless you actually send the code
> to a printer (which I suppose hardly anyone does nowadays).
>

I guess you're right, at this point it's mostly aesthetics. ^L is just
whitespace and the compiler ignores it, likely a relic from the old
days. Some editors display it a bit oddly, and most of the kernel seems
to have pruned these over time, but a few still linger in arch/alpha,
which fits the age and heritage there.

Magnus

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/1] alpha: trivial: remove ^L chars
  2026-01-06 16:30       ` Magnus Lindholm
@ 2026-01-06 17:17         ` Maciej W. Rozycki
  0 siblings, 0 replies; 8+ messages in thread
From: Maciej W. Rozycki @ 2026-01-06 17:17 UTC (permalink / raw)
  To: Magnus Lindholm
  Cc: Askar Safin, Richard Henderson, Matt Turner, linux-alpha,
	kernel-janitors, linux-kernel, patches

On Tue, 6 Jan 2026, Magnus Lindholm wrote:

> >  As a matter of interest, why would the presence of ^L characters cause
> > any issues?  That is just another instance of white space and it has been
> > commonly used across some source code to separate functional parts, e.g.
> > in the GNU toolchain.  It can be ignored unless you actually send the code
> > to a printer (which I suppose hardly anyone does nowadays).
> 
> I guess you're right, at this point it's mostly aesthetics. ^L is just
> whitespace and the compiler ignores it, likely a relic from the old
> days. Some editors display it a bit oddly, and most of the kernel seems
> to have pruned these over time, but a few still linger in arch/alpha,
> which fits the age and heritage there.

 FWIW, ^L is printed just as ^L here (VIM), but I can imagine a GUI text 
editor might show "--- page break ---" or suchlike in a graphical form 
instead.  If it does cause odd behaviour in an editor, then it should be 
filed as a bug in said editor IMO; it's a standard ASCII character after 
all and a valid preprocessing token separator in ISO C (IOW the compiler 
does not ignore it, but treats according to the standard).

 As to the change proposed itself I have no opinion either way; I agree 
that the commit description leaves something to desire.

  Maciej

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/1] alpha: trivial: remove ^L chars
  2026-01-06 13:17     ` Maciej W. Rozycki
  2026-01-06 16:30       ` Magnus Lindholm
@ 2026-01-11 11:35       ` Askar Safin
  2026-01-11 17:58         ` Maciej W. Rozycki
  1 sibling, 1 reply; 8+ messages in thread
From: Askar Safin @ 2026-01-11 11:35 UTC (permalink / raw)
  To: macro
  Cc: kernel-janitors, linmag7, linux-alpha, linux-kernel, mattst88,
	patches, richard.henderson

"Maciej W. Rozycki" <macro@orcam.me.uk>:
>  As a matter of interest, why would the presence of ^L characters cause 
> any issues?  That is just another instance of white space and it has been 

I have shell script, which allows me to remove given config (for example,
CONFIG_NET) from whole Linux source tree. To do this, this script parses
.c files, Kconfig files and makefiles. So, I want them to be as predictable
and easy-to-parse as possible.

P. S. I don't see your emails in my gmail inbox (not even in spam folder).

-- 
Askar Safin

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/1] alpha: trivial: remove ^L chars
  2026-01-11 11:35       ` Askar Safin
@ 2026-01-11 17:58         ` Maciej W. Rozycki
  0 siblings, 0 replies; 8+ messages in thread
From: Maciej W. Rozycki @ 2026-01-11 17:58 UTC (permalink / raw)
  To: Askar Safin
  Cc: kernel-janitors, linmag7, linux-alpha, linux-kernel, mattst88,
	patches, richard.henderson

On Sun, 11 Jan 2026, Askar Safin wrote:

> >  As a matter of interest, why would the presence of ^L characters cause 
> > any issues?  That is just another instance of white space and it has been 
> 
> I have shell script, which allows me to remove given config (for example,
> CONFIG_NET) from whole Linux source tree. To do this, this script parses
> .c files, Kconfig files and makefiles. So, I want them to be as predictable
> and easy-to-parse as possible.

 What prevents your shell script from interpreting ^L as yet another 
white-space character?  I don't think any limitation of the tool you've 
chosen is by itself a good justification to change the work the tool is 
used on.  Fix your tool or use another instead, i.e. match your tools to 
the work and not the other way round.

> P. S. I don't see your emails in my gmail inbox (not even in spam folder).

 Correct, GMail rejects e-mail sent from here.  It has for a while now.  

  Maciej

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-01-11 17:59 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-28  6:34 [PATCH 0/1] alpha: trivial: remove ^L chars Askar Safin
2025-12-28  6:34 ` [PATCH 1/1] " Askar Safin
2026-01-05 10:38   ` Magnus Lindholm
2026-01-06 13:17     ` Maciej W. Rozycki
2026-01-06 16:30       ` Magnus Lindholm
2026-01-06 17:17         ` Maciej W. Rozycki
2026-01-11 11:35       ` Askar Safin
2026-01-11 17:58         ` Maciej W. Rozycki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox