ALPHA: missing reference to barrier()

ALPHA: missing reference to barrier()

[alpha @ steudten Engineering]

[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]

ONLY for linux ALPHA:

Please add patch to the source tree..

Hello

In the kernel source 2.6.14 from kernel.org build with the given config1, the
symbol barrier() is missing in linux/include/asm-alpha/atomic.h with gcc 4.0.1 from
FC4.

This is defined in linux/compiler.h or asm/compiler.h.

PATCH:
------------------
--- include/asm-alpha/atomic.h.orig     2005-11-03 18:45:21.000000000 +0100
+++ include/asm-alpha/atomic.h  2005-11-03 18:45:46.000000000 +0100
@@ -1,6 +1,7 @@
 #ifndef _ALPHA_ATOMIC_H
 #define _ALPHA_ATOMIC_H

+#include <asm/compiler.h>
 #include <asm/barrier.h>

 /*
-------------------

CC      fs/nfsctl.o
In file included from include/linux/file.h:8,
                 from fs/nfsctl.c:8:
include/asm/atomic.h: In function 'atomic_add_return':
include/asm/atomic.h:105: warning: implicit declaration of function 'barrier'
  CC      fs/binfmt_script.o
  CC      fs/binfmt_elf.o

 CC      net/ipv4/raw.o
In file included from net/ipv4/raw.c:43:
include/asm/atomic.h: In function 'atomic_add_return':
include/asm/atomic.h:105: warning: implicit declaration of function 'barrier'
  CC      net/ipv4/udp.o

net/built-in.o(.text+0x580e0): In function `raw_rcv_skb':
: undefined reference to `barrier'
net/built-in.o(.text+0x580e4): In function `raw_rcv_skb':
: undefined reference to `barrier'
net/built-in.o(.text+0x58104): In function `raw_rcv_skb':
: undefined reference to `barrier'
net/built-in.o(.text+0x58108): In function `raw_rcv_skb':
: undefined reference to `barrier'
net/built-in.o(.text+0x58650): In function `raw_rcv':




[-- Attachment #2: config1.gz --]
[-- Type: application/x-gzip, Size: 2938 bytes --]

Re: ALPHA: missing reference to barrier()

[Daniel Drake]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

alpha @ steudten Engineering wrote:
> ONLY for linux ALPHA:
> 
> Please add patch to the source tree..
> 
> Hello
> 
> In the kernel source 2.6.14 from kernel.org build with the given config1, the
> symbol barrier() is missing in linux/include/asm-alpha/atomic.h with gcc 4.0.1 from
> FC4.
> 
> This is defined in linux/compiler.h or asm/compiler.h.

An alternative patch has already been merged into Linus' git tree. It should 
fix your problem.

Daniel

[-- Attachment #2: 1305_alpha-barrier-compile.patch --]
[-- Type: text/x-patch, Size: 752 bytes --]

From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Date: Sun, 30 Oct 2005 01:15:43 +0000 (-0700)
Subject:     [PATCH] fix alpha breakage
X-Git-Url: http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=63f324cf0792ed69089b79d6921ba3aaea97af50

  [PATCH] fix alpha breakage
  
  barrier.h uses barrier() in non-SMP case.  And doesn't include compiler.h.
  
  Cc: Al Viro <viro@ftp.linux.org.uk>
  Signed-off-by: Andrew Morton <akpm@osdl.org>
  Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

--- a/include/asm-alpha/barrier.h
+++ b/include/asm-alpha/barrier.h
@@ -1,6 +1,8 @@
 #ifndef __BARRIER_H
 #define __BARRIER_H
 
+#include <asm/compiler.h>
+
 #define mb() \
 __asm__ __volatile__("mb": : :"memory")