From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH v2 1/6] Add new macros for page-aligned data and bss sections. Date: Fri, 01 May 2009 10:47:48 -0700 Message-ID: <49FB35C4.6060107@zytor.com> References: <1241121253-32341-1-git-send-email-tabbott@mit.edu> <1241121253-32341-2-git-send-email-tabbott@mit.edu> <20090501091848.GB18326@uranus.ravnborg.org> <49FB2449.1010301@zytor.com> <20090501171717.GA26401@uranus.ravnborg.org> <49FB2EDC.9050300@zytor.com> <20090501174457.GA26559@uranus.ravnborg.org> Reply-To: microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090501174457.GA26559-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org> Sender: owner-microblaze-uclinux-FR6EJeJVuqfA6Z3fQjNZrN9u6TNh0Fb7@public.gmane.org List-Id: Content-Type: text/plain; charset="us-ascii" To: Sam Ravnborg Cc: Tim Abbott , Linux kernel mailing list , Anders Kaseorg , Waseem Daher , Denys Vlasenko , Jeff Arnold , Benjamin Herrenschmidt , Bryan Wu , Chris Zankel , Cyrill Gorcunov , David Howells , "David S. Miller" , dev-etrax-VrBV9hrLPhE@public.gmane.org, Geert Uytterhoeven , Greg Ungerer , Haavard Skinnemoen , Heiko Carstens , Helge Deller , Hirokazu Takata , Ingo Molnar , Jeff Dike Sam Ravnborg wrote: >> >> What's wrong with @? > arm does not support it :-( > I recall it denote a comment in arm assembler. > > I could do some magic to detect the ARM case but I'm reluctant to do so. > I could also ignore the arm issue for now as it is not used by arm, > but that strikes me as the wrong approach. > If we really have to use different tokens, I would say: #ifdef __ARM__ # define _PROGBITS %progbits /* or whatever */ # define _NOBITS %nobits #else # define _PROGBITS @progbits # define _NOBITS @nobits #endif Otherwise we probably need to ask the binutils people... -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.