From: Richard Henderson <rth@twiddle.net>
To: Tim Abbott <tabbott@ksplice.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Anders Kaseorg <andersk@ksplice.com>,
Nelson Elhage <nelhage@ksplice.com>,
linux-alpha@vger.kernel.org
Subject: Re: [PATCH 1/2] alpha: use .data.init_task instead of .data.init_thread.
Date: Fri, 31 Jul 2009 16:30:57 -0700 [thread overview]
Message-ID: <4A737EB1.1000602@twiddle.net> (raw)
In-Reply-To: <alpine.DEB.1.10.0907311739040.2539@vinegar-pot.mit.edu>
On 07/31/2009 03:02 PM, Tim Abbott wrote:
> The INIT_TASK_DATA(THREAD_SIZE) macro call aligns to THREAD_SIZE (=
> 2*PAGE_SIZE). So I'm not removing the 2 page alignment; I'm just moving
> it along with the code that needs to be aligned.
Sure.
>
> This change:
>
> - . = ALIGN(2 * PAGE_SIZE);
> + . = ALIGN(PAGE_SIZE);
> __init_end = .;
>
> removes the now-unnecessary (2 * PAGE_SIZE) alignment for __init_end
> caused by moving .data.init_task (it should have been in the first patch).
While it's technically unnecessary, it's also very much desired.
Think about it. Suppose we have 9 pages of init, followed by the
two-page-aligned INIT_TASK_DATA. So we get a page worth of padding
added. It's better to have the two-page-alignment within the init
section so as to get 10 pages of init followed by no padding. In
this way the page of padding gets freed with the rest of init.
Are you following me at all here?
r~
next prev parent reply other threads:[~2009-07-31 23:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 20:56 [PATCH 1/2] alpha: use .data.init_task instead of .data.init_thread Tim Abbott
2009-07-31 21:23 ` Richard Henderson
2009-07-31 21:38 ` Richard Henderson
2009-07-31 23:44 ` Tim Abbott
2009-07-31 22:02 ` Tim Abbott
2009-07-31 23:30 ` Richard Henderson [this message]
2009-07-31 23:56 ` Tim Abbott
2009-08-02 16:25 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A737EB1.1000602@twiddle.net \
--to=rth@twiddle.net \
--cc=andersk@ksplice.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nelhage@ksplice.com \
--cc=sam@ravnborg.org \
--cc=tabbott@ksplice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).