* [PATCH] alpha: fix build breakage in asm/cacheflush.h [not found] <20100914002132.bf17c19e.sfr@canb.auug.org.au> @ 2010-09-14 9:00 ` Tejun Heo 2010-09-19 4:52 ` Matt Turner 0 siblings, 1 reply; 2+ messages in thread From: Tejun Heo @ 2010-09-14 9:00 UTC (permalink / raw) To: Richard Henderson, Ivan Kokshaysky, Matt Turner, linux-alpha, Stephen Rothwell Cc: Rusty Russell, Christoph Lameter, Ingo Molnar, linux-next, linux-kernel Alpha SMP flush_icache_user_range() is implemented as an inline function inside include/asm/cacheflush.h. It dereferences @current but doesn't include linux/sched.h and thus causes build failure if linux/sched.h wasn't included previously. Fix it by including the needed header file explicitly. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> --- arch/alpha/include/asm/cacheflush.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/alpha/include/asm/cacheflush.h b/arch/alpha/include/asm/cacheflush.h index 01d71e1..012f124 100644 --- a/arch/alpha/include/asm/cacheflush.h +++ b/arch/alpha/include/asm/cacheflush.h @@ -43,6 +43,8 @@ extern void smp_imb(void); /* ??? Ought to use this in arch/alpha/kernel/signal.c too. */ #ifndef CONFIG_SMP +#include <linux/sched.h> + extern void __load_new_mm_context(struct mm_struct *); static inline void flush_icache_user_range(struct vm_area_struct *vma, struct page *page, ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] alpha: fix build breakage in asm/cacheflush.h 2010-09-14 9:00 ` [PATCH] alpha: fix build breakage in asm/cacheflush.h Tejun Heo @ 2010-09-19 4:52 ` Matt Turner 0 siblings, 0 replies; 2+ messages in thread From: Matt Turner @ 2010-09-19 4:52 UTC (permalink / raw) To: Tejun Heo Cc: Richard Henderson, Ivan Kokshaysky, linux-alpha, Stephen Rothwell, Rusty Russell, Christoph Lameter, Ingo Molnar, linux-next, linux-kernel On Tue, Sep 14, 2010 at 5:00 AM, Tejun Heo <tj@kernel.org> wrote: > Alpha SMP flush_icache_user_range() is implemented as an inline > function inside include/asm/cacheflush.h. It dereferences @current > but doesn't include linux/sched.h and thus causes build failure if > linux/sched.h wasn't included previously. Fix it by including the > needed header file explicitly. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > --- > arch/alpha/include/asm/cacheflush.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/alpha/include/asm/cacheflush.h b/arch/alpha/include/asm/cacheflush.h > index 01d71e1..012f124 100644 > --- a/arch/alpha/include/asm/cacheflush.h > +++ b/arch/alpha/include/asm/cacheflush.h > @@ -43,6 +43,8 @@ extern void smp_imb(void); > /* ??? Ought to use this in arch/alpha/kernel/signal.c too. */ > > #ifndef CONFIG_SMP > +#include <linux/sched.h> > + > extern void __load_new_mm_context(struct mm_struct *); > static inline void > flush_icache_user_range(struct vm_area_struct *vma, struct page *page, Thanks! Applied this to my tree and sent it to Linus. -- To unsubscribe from this list: send the line "unsubscribe linux-alpha" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-19 4:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100914002132.bf17c19e.sfr@canb.auug.org.au>
2010-09-14 9:00 ` [PATCH] alpha: fix build breakage in asm/cacheflush.h Tejun Heo
2010-09-19 4:52 ` Matt Turner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).