From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xi Ruoyao Subject: Re: [RFC PATCH] asm-generic: Unify uapi bitsperlong.h Date: Fri, 09 Jun 2023 21:05:07 +0800 Message-ID: <5de9d69817138f2ccae0867b5ccb602dcfa007a3.camel@xry111.site> References: <1683615903-10862-1-git-send-email-yangtiezhu@loongson.cn> <76d3be65-91df-7969-5303-38231a7df926@loongson.cn> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1686315913; bh=hT63nSeqfXe+w/wcTH/EVqDDlEdDBDYjRZhYbxbpM9E=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=npo+qrCHsIrTavth6RFp9whOgzBlVXmzRzYXUH+dxBlx16fsDq62B5M0BsrtN4VtJ 1fdfpCWNVPfQBRPxlsk/T5jnywsDDxzlQF9T3tubgjW3v4DrYce6kTsX/rRJiWMx5i hBEItCRBrPuBf/r8DMY+d6WFyBryIiRnxabHdAlU= In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" To: Tiezhu Yang , Arnd Bergmann Cc: Linux-Arch , linux-s390@vger.kernel.org, llvm@lists.linux.dev, linux-ia64@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-parisc@vger.kernel.org, x86@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, loongarch@lists.linux.dev, linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongson-kernel@lists.loongnix.cn On Fri, 2023-06-09 at 14:50 +0800, Tiezhu Yang wrote: /* snip */ > > > > In musl, the documentation states that at least gcc-3.4 or > > > > clang-3.2 are required, which probably predate the > > > > __SIZEOF_LONG__ macro. Indeed, I've digged some history and __SIZEOF_LONG__ was added into GCC- 4.3 (in 2008). And I didn't realize the bitsperlong.h in tools directory is a copy from uapi. > > > > On the other hand, musl was only > > > > released in 2011, and building musl itself explicitly > > > > does not require kernel uapi headers, so this may not > > > > be too critical. > Only arm64, riscv and loongarch belong to the newer architectures > which are related with this change, I am not sure it is necessary > to "unify" uapi bitsperlong.h for them. At least it will stop the engineers working on "the next architecture" from adding an unneeded bitsperlong.h :). --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University