From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Laight Subject: RE: [PATCH v2 1/6] ia64, processor: fix -Wincompatible-pointer-types in ia64_get_irr() Date: Fri, 10 Jun 2022 12:18:03 +0000 Message-ID: <8711f7d6bdc148bd916d87515e71b3c2@AcuMS.aculab.com> References: <20220610113427.908751-1-alexandr.lobakin@intel.com> <20220610113427.908751-2-alexandr.lobakin@intel.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20220610113427.908751-2-alexandr.lobakin@intel.com> Content-Language: en-US List-ID: Content-Type: text/plain; charset="us-ascii" To: 'Alexander Lobakin' , Arnd Bergmann , Yury Norov Cc: Andy Shevchenko , Mark Rutland , Matt Turner , Brian Cain , Geert Uytterhoeven , Yoshinori Sato , Rich Felker , "David S. Miller" , Kees Cook , "Peter Zijlstra (Intel)" , Marco Elver , Borislav Petkov , Tony Luck , Greg Kroah-Hartman , "linux-alpha@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" <> From: Alexander Lobakin > Sent: 10 June 2022 12:34 > > test_bit(), as any other bitmap op, takes `unsigned long *` as a > second argument (pointer to the actual bitmap), as any bitmap > itself is an array of unsigned longs. However, the ia64_get_irr() > code passes a ref to `u64` as a second argument. > This works with the ia64 bitops implementation due to that they > have `void *` as the second argument and then cast it later on. > This works with the bitmap API itself due to that `unsigned long` > has the same size on ia64 as `u64` (`unsigned long long`), but > from the compiler PoV those two are different. > Define @irr as `unsigned long` to fix that. That implies no > functional changes. Has been hidden for 16 years! Wouldn't it be better to just test the bit? As in: return irr & (1ull << bit); David > > Fixes: a58786917ce2 ("[IA64] avoid broken SAL_CACHE_FLUSH implementations") > Cc: stable@vger.kernel.org # 2.6.16+ > Reported-by: kernel test robot > Signed-off-by: Alexander Lobakin > --- > arch/ia64/include/asm/processor.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/ia64/include/asm/processor.h b/arch/ia64/include/asm/processor.h > index 7cbce290f4e5..757c2f6d8d4b 100644 > --- a/arch/ia64/include/asm/processor.h > +++ b/arch/ia64/include/asm/processor.h > @@ -538,7 +538,7 @@ ia64_get_irr(unsigned int vector) > { > unsigned int reg = vector / 64; > unsigned int bit = vector % 64; > - u64 irr; > + unsigned long irr; > > switch (reg) { > case 0: irr = ia64_getreg(_IA64_REG_CR_IRR0); break; > -- > 2.36.1 - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)