From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 7/9] signal: Make individual tasks exiting a first class concept. Date: Thu, 24 Jun 2021 16:37:19 -0500 Message-ID: <87a6nf54hc.fsf@disp2133> References: <87sg1lwhvm.fsf@disp2133> <6e47eff8-d0a4-8390-1222-e975bfbf3a65@gmail.com> <924ec53c-2fd9-2e1c-bbb1-3fda49809be4@gmail.com> <87eed4v2dc.fsf@disp2133> <5929e116-fa61-b211-342a-c706dcb834ca@gmail.com> <87fsxjorgs.fsf@disp2133> <87a6njf0ia.fsf@disp2133> <87tulpbp19.fsf@disp2133> <87zgvgabw1.fsf@disp2133> <875yy3850g.fsf_-_@disp2133> <87y2az5bmt.fsf_-_@disp2133> Mime-Version: 1.0 Return-path: In-Reply-To: (Linus Torvalds's message of "Thu, 24 Jun 2021 13:11:18 -0700") List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Torvalds Cc: Al Viro , Michael Schmitz , linux-arch , Jens Axboe , Oleg Nesterov , Linux Kernel Mailing List , Richard Henderson , Ivan Kokshaysky , Matt Turner , alpha , Geert Uytterhoeven , linux-m68k , Arnd Bergmann , Tejun Heo , Kees Cook Linus Torvalds writes: > On Thu, Jun 24, 2021 at 12:03 PM Eric W. Biederman > wrote: >> >> Implement start_task_exit_locked and rewrite the de_thread logic >> in exec using it. >> >> Calling start_task_exit_locked is equivalent to asyncrhonously >> calling exit(2) aka pthread_exit on a task. > > Ok, so this is the patch that makes me go "Yeah, this seems to all go together". > > The whole "start_exit()" thing seemed fairly sane as an interesting > concept to the whole ptrace notification thing, but this one actually > made me think it makes conceptual sense and how we had exactly that > "start exit asynchronously" case already in zap_other_threads(). > > So doing that zap_other_threads() as that async exit makes me just > thin kthat yes, this series is the right thing, because it not only > cleans up the ptrace condition, it makes sense in this entirely > unrelated area too. > > So I think I'm convinced. I'd like Oleg in particular to Ack this > series, and Al to look it over, but I do think this is the right > direction. Thanks. It took a bit of exploration and playing with things to get here, but I had the same sense. Next round I will see if I can clean up the patches a bit more. Eric