From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation) Date: Fri, 10 Jan 2020 15:33:11 +0200 Message-ID: <87eew7sag8.fsf@codeaurora.org> References: <20200108200528.4614-1-krzk@kernel.org> <20200108200528.4614-10-krzk@kernel.org> Mime-Version: 1.0 Return-path: DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1578663513; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=R0YUROCJJ/dav0PwJDeXKOS0FaitFefZwp9Lb2TmZvI=; b=MGHpWg830iuM8GhZiRmr9ec3uWlRhdail0fdJf8BKKYRbH+s/dgJ10xJ6xCQVGrh8Voj601C B89eNzzgnMEqokd7S5HvhplL3/SoJoGYHH0HNaW50CE6/gDTtHvR7+ZGBuNERfmaeT35sNen rnRwBaxtDId/SIdlIFJHV8rAVoM= In-Reply-To: <20200108200528.4614-10-krzk@kernel.org> (Krzysztof Kozlowski's message of "Wed, 8 Jan 2020 21:05:28 +0100") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Krzysztof Kozlowski Cc: Rich Felker , Jiri Slaby , Geert Uytterhoeven , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , netdev@vger.kernel.org, Paul Mackerras , linux-arch@vger.kernel.org, Dave Jiang , Yoshinori Sato , Helge Deller , linux-sh@vger.kernel.org, Alexey Brodkin , Ben Skeggs , nouveau@lists.freedesktop.org, Dave Airlie , Matt Turner , linux-snps-arc@lists.infradead.org, Nick Kossifidis , Allen Hubbe , Arnd Bergmann Krzysztof Kozlowski writes: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/net/wireless/ath/ath5k/ahb.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) No need to have "net: wireless: " in the title, otherwise looks good. Acked-by: Kalle Valo -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches