From: Kalle Valo <kvalo@codeaurora.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rich Felker <dalias@libc.org>, Jiri Slaby <jirislaby@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Airlie <airlied@linux.ie>, Jason Wang <jasowang@redhat.com>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-arch@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Helge Deller <deller@gmx.de>,
linux-sh@vger.kernel.org, Alexey Brodkin <abrodkin@synopsys.com>,
Ben Skeggs <bskeggs@redhat.com>,
nouveau@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>,
Matt Turner <mattst88@gmail.com>,
linux-snps-arc@lists.infradead.org,
Nick Kossifidis <mickflemm@gmail.com>,
Allen Hubbe <allenbh@gmail.com>, Arnd Bergmann <arnd@arn>
Subject: Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation)
Date: Fri, 10 Jan 2020 15:32:13 +0200 [thread overview]
Message-ID: <87imljsahu.fsf@codeaurora.org> (raw)
In-Reply-To: <20200108200528.4614-3-krzk@kernel.org> (Krzysztof Kozlowski's message of "Wed, 8 Jan 2020 21:05:21 +0100")
Krzysztof Kozlowski <krzk@kernel.org> writes:
> The ioreadX() helpers have inconsistent interface. On some architectures
> void *__iomem address argument is a pointer to const, on some not.
>
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> ---
>
> Changes since v1:
> 1. Add Geert's review.
> ---
> drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
No need to have "net: wireless: " in the title, this is enough.
rtl818x: Constify ioreadX() iomem argument (as in generic implementation)
I assume someone else will take this so here's my ack:
Acked-by: Kalle Valo <kvalo@codeaurora.org>
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-01-10 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200108200528.4614-1-krzk@kernel.org>
[not found] ` <20200108200528.4614-7-krzk@kernel.org>
2020-01-09 6:04 ` [PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementation) Thomas Zimmermann
[not found] ` <20200108200528.4614-6-krzk@kernel.org>
2020-01-09 6:59 ` [PATCH v2 5/9] arc: " Alexey Brodkin
[not found] ` <20200108200528.4614-2-krzk@kernel.org>
2020-01-08 20:53 ` [PATCH v2 1/9] iomap: " Arnd Bergmann
2020-01-09 12:00 ` Geert Uytterhoeven
[not found] ` <20200108200528.4614-3-krzk@kernel.org>
2020-01-10 13:32 ` Kalle Valo [this message]
2020-01-26 15:11 ` [PATCH v2 2/9] net: wireless: rtl818x: " Kalle Valo
2020-01-26 15:11 ` Kalle Valo
2020-01-26 15:11 ` Kalle Valo
[not found] ` <20200108200528.4614-10-krzk@kernel.org>
2020-01-10 13:33 ` [PATCH v2 9/9] net: wireless: ath5k: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imljsahu.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=allenbh@gmail.com \
--cc=arnd@arn \
--cc=bskeggs@redhat.com \
--cc=dalias@libc.org \
--cc=dave.jiang@intel.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=jasowang@redhat.com \
--cc=jirislaby@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mattst88@gmail.com \
--cc=mickflemm@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=paulus@samba.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).