From: Dave Airlie <airlied@gmail.com>
To: Jay Estabrook <jay.estabrook@gmail.com>
Cc: linux-alpha <linux-alpha@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Matt Turner <mattst88@gmail.com>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
airlied@linux.ie
Subject: Re: [PATCH 3/3] alpha, drm: Add Alpha support to Radeon DRM code
Date: Tue, 14 Jun 2011 09:35:30 +1000 [thread overview]
Message-ID: <BANLkTinvXFV1bObeaym6A4VEcxv0jN+zXQ@mail.gmail.com> (raw)
In-Reply-To: <20110609182021.73726ea3.jay.estabrook_gmail.com@gmail.com>
On Fri, Jun 10, 2011 at 8:20 AM, Jay Estabrook <jay.estabrook@gmail.com> wrote:
>
> Alpha needs to have the system bus address for the device's local
> memory available, so that it can be returned to user-level, where
> it may be used in an mmap(). So, we make bus.addr hold the ioremap()
> return for kernel use, and then we can modify bus.base appropriately.
>
I don't get this. why is mmap passing in an address? we don't do that anymore.
When you mmap the device node it passes back a hashed offset in the
table, that the
kernel then translates into a proper address and sets up the page tables.
So I really don't get what this patch is doing, either the
explaination of what it is doing is wrong
or it is wrong.
Dave.
next prev parent reply other threads:[~2011-06-13 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 22:20 [PATCH 3/3] alpha, drm: Add Alpha support to Radeon DRM code Jay Estabrook
2011-06-13 23:35 ` Dave Airlie [this message]
2011-06-15 2:38 ` Jay Estabrook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinvXFV1bObeaym6A4VEcxv0jN+zXQ@mail.gmail.com \
--to=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jay.estabrook@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).