From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hugh Dickins Subject: Re: 2.6.22-rc6 bad page error Date: Thu, 12 Jul 2007 17:13:46 +0100 (BST) Message-ID: References: <20070709185324.387ACDBA1@gherkin.frus.com> <20070711170245.A1148@jurassic.park.msu.ru> <20070712134606.A10012@jurassic.park.msu.ru> Mime-Version: 1.0 Return-path: In-Reply-To: <20070712134606.A10012@jurassic.park.msu.ru> Sender: linux-alpha-owner@vger.kernel.org List-Id: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bill Irwin Cc: Ivan Kokshaysky , Bob Tracy , Michal Piotrowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, Andrew Morton On Thu, 12 Jul 2007, Ivan Kokshaysky wrote: > On Wed, Jul 11, 2007 at 06:07:59PM +0100, Hugh Dickins wrote: > > > > + return __pci_alloc_consistent(dev, size, dma, GFP_ATOMIC); > > > > I was going to ask you why that needs to be GFP_ATOMIC on Alpha. > > But find you're following the example of asm-generic and others. > > So really should be asking Sparc how it gets away with GFP_KERNEL. > > According to DMA-mapping.txt GFP_ATOMIC is mandatory for > pci_alloc_consistent() since it can be called from interrupt context. > So sparc code is probably incorrect... Hi Bill, we've veered away from the original topic, and are wondering how the sparc32 pci_alloc_consistent() gets away with using GFP_KERNEL, when GFP_ATOMIC seems to be required? Hugh